Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: T5400: move build of libvyosconfig to vyos-1x #923

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Docker: T5400: move build of libvyosconfig to vyos-1x #923

merged 1 commit into from
Mar 5, 2025

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Mar 4, 2025 •
edited
Loading

Change summary

libvyosconfig is both a build and a run dependency of vyos-1x. Satisfying the build dependency within the Docker image requires coordination of updates to vyos-build/libvyosconfig/vyos-1x on any changes to the library; simplify this process by moving the build to a step of the vyos-1x Makefile.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):
    Adjust build process.

Related Task(s)

Related PR(s)

vyos/vyos-1x#4378

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro
Docker: T5400: move build of libvyosconfig to vyos-1x
ee0c643 
libvyosconfig is both a build and a run dependency of vyos-1x.
Satisfying the build dependency within the Docker image requires
coordination of updates to vyos-build/libvyosconfig/vyos-1x on any
changes to the library; simplify this process by moving the build to a
step of the vyos-1x Makefile.
@jestabro jestabro self-assigned this Mar 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Mar 4, 2025
@jestabro jestabro mentioned this pull request Mar 4, 2025
Merged
12 tasks
@c-po c-po mentioned this pull request Mar 4, 2025
Merged
12 tasks
@jestabro jestabro marked this pull request as ready for review March 4, 2025 15:10
@jestabro jestabro requested a review from a team as a code owner March 4, 2025 15:10
@jestabro jestabro marked this pull request as draft March 4, 2025 15:10
@jestabro jestabro marked this pull request as ready for review March 5, 2025 08:18
@c-po c-po merged commit f23b204 into vyos:current Mar 5, 2025
9 checks passed
@vyosbot vyosbot added the mirror-initiated This PR initiated for mirror sync workflow label Mar 5, 2025
@kumvijaya kumvijaya added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current VyOS rolling release mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jestabro @c-po @kumvijaya @vyosbot