Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow empty method-specific-id in ABNF. #216

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

peacekeeper
Copy link
Contributor

@peacekeeper peacekeeper commented Mar 5, 2020

Addresses #34


Preview | Diff

@peacekeeper
Copy link
Contributor Author

This changes the method-specific-id ABNF rule to allow leading and consecutive colons, but disallows a trailing colon or an empty method-specific-id.

E.g. allowed:

did:ex:123
did:ex::123
did:ex:sub:123
did:ex:sub::more:123
did:ex:sub::more::123

E.g. disallowed:

did:ex
did:ex:
did:ex:sub:

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for a non-editor review before merging because it's a normative change.

@davidlehn
Copy link
Contributor

#215 proposes text saying use of colons is "entirely method specific". That seems to be a slight conflict with also restricting their trailing use here.

@peacekeeper
Copy link
Contributor Author

That seems to be a slight conflict with also restricting their trailing use here.

Thanks @davidlehn for pointing this out, I just updated #215 to reflect this. Do you agree with this change?

@davidlehn
Copy link
Contributor

@peacekeeper Sure. I added related comments to the other PR.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normative, multiple reviews, uncontroversial, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants