-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow empty method-specific-id in ABNF. #216
Conversation
This changes the E.g. allowed:
E.g. disallowed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for a non-editor review before merging because it's a normative change.
#215 proposes text saying use of colons is "entirely method specific". That seems to be a slight conflict with also restricting their trailing use here. |
Thanks @davidlehn for pointing this out, I just updated #215 to reflect this. Do you agree with this change? |
@peacekeeper Sure. I added related comments to the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normative, multiple reviews, uncontroversial, merging.
Addresses #34
Preview | Diff