-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer to VC-SPECS-DIR for proof types. #1212
Conversation
7f4f28c
to
06ca821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems weird to use vc specs dir for data integrity and use the core data model for vc-jwt... I wonder if we can point both to the core data model section, and mention VC specs dir from there.
I'd be fine with that... this PR is attempting to address an issue you brought up, so you tell me what you want to see in the spec and I'll try to make it happen. Options include:
Pick a direction, and ideally suggest some concrete text, to help me refine this PR so that it closes the issue you raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this. I can also see some justification for tweaking it as @msporny described above. Of the listed options, I'm most inclined to --
- Add VC-JWT to the section on Proofs in VC-SPECS (or maybe rename that section to "Securing Mechanisms" or something that allows us to put any securing mechanism in there).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this option:
Add VC-JWT to the section on Proofs in VC-SPECS (or maybe rename that section to "Securing Mechanisms" or something that allows us to put any securing mechanism in there).
Co-authored-by: Sebastian Crane <[email protected]>
@OR13 I need you to signal a direction you'd like this PR to go in among these options #1212 (comment) or another one provided by you. Others in the thread have provided input, so if you are aligned w/ their input, we might have a clear path forward with this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to link to the specs directory for both securing mechanism... Instead of separating them the way the current text does.
Specifically, we should link to the section of the directory that covers media types that secure the core data model, and we should include the core data model media types in that section, for the case that data integrity proofs are used... Since they have no separate media type.
The issue was discussed in a meeting on 2023-08-01
View the transcript1.4. Refer to VC-SPECS-DIR for proof types. (pr vc-data-model#1212)See github pull request vc-data-model#1212. Brent Zundel: this is 'Refer to VC Specs Dir for Proof Types'. two change requests, from Orie and Sebastian. Sebastian Crane: let me look.. Brent Zundel: manu, looks like Orie has a change suggestion, if you could .. Manu Sporny: I think I disagree with the change suggestion, mainly because the request was to refer to the VC Specs Dir. Joe Andrieu: I'm concerned about the position you're taking here, Manu. Manu Sporny: that's not the intent. we're just saying - securing mechanisms exist. Here's two examples. Others are in the specs dir. Joe Andrieu: I'll take another look. Sebastian Crane: I think my comment has been addressed. Brent Zundel: next steps.. we have a change request from Orie. Joe is reviewing.. Manu Sporny: or we could accept it, I don't hear anyone arguing against not mentioning at all. Ted Thibodeau Jr.: just reading this over, Manu, I think you're mistaken as to what it currently says. Manu Sporny: ah, I see the reading you're referring to. Brent Zundel: sounds like there's a bit of tweaking needed. Manu Sporny: yes. Brent Zundel: sufficient steps taken, lets move on to 1215. |
The issue was discussed in a meeting on 2023-08-09
View the transcript2.5. Refer to VC-SPECS-DIR for proof types. (pr vc-data-model#1212)See github pull request vc-data-model#1212. Manu Sporny: PR 1212 examples of securing mechanisms in spec. Point to specifications or directory? Need PR about media types? Orie Steele: VCs with some securing mechanisms, with DI proofs; two specs; or media types; This or that language in DM spec. Joe Andrieu: this establishes related specs into a privileged position...
Manu Sporny: securing mechanisms we have vetted here and those not. Anyone can add to specs dir. No review...
Manu Sporny: very dangerous thing; any mechanism...
Joe Andrieu: I think anything does go; people can come up with new crypto; a directory is okay; our mechanisms are published as recs. Sebastian Crane: be careful, don't devalue our (WG) opinion. Kristina Yasuda: safely change to MAY... Manu Sporny: we don't say what has/hasn't been vetted in registry? The VC DM doesn't say what has been vetted.
Manu Sporny: what sections/where to put? Orie Steele: if media types is merge is will be obvious;. See github pull request vc-specs-dir#14.
Manu Sporny: blocking on Kristina PR 14; create media type in specs dir; then merge.
Joe Andrieu: avoid that directory is a registry.
See github issue vc-specs-dir#27. |
The issue was discussed in a meeting on 2023-08-15
View the transcript1.4. Refer to VC-SPECS-DIR for proof types. (pr vc-data-model#1212)See github pull request vc-data-model#1212. Brent Zundel: next up PR 1212: Refer to VC-SPECS-DIR for proof types. many approvals. one outstanding request from Orie who is not on the call. Manu Sporny: looking to see where the objection is...would rather link to the specs dir for both securing mechanisms for this particular PR re:vc-specs-dir#14 which was merged. Brent Zundel: Orie has joined, which changes would you like to see in 1212. sorry for ambushing you. Orie Steele: expect there to be other representations of VCs. expect there to be media types that distinguish them. easier to refer to the specs dir where those media types exist, instead of our work item continuing to refer to the two current mechanisms over and over again. Manu Sporny: I will refer to the specs directory and two different places: one for proofs, one for media types. Orie Steele: I would refer to just the media types section, and add to the section vc+ld+json as a media type which can contain embedded proofs. just refer to the media type section. Manu Sporny: previously kristina had objected putting the base media type into the media types section. if you're OK with that we can do what Orie said.
Brent Zundel: any objections? [none heard]. |
Co-authored-by: Orie Steele <[email protected]>
Editorial, multiple reviews, changes requested and made, no objections, merging. |
This PR attempts to address issue #1105 by explicitly stating that
proof
types SHOULD come from the VC-SPECS-DIR. The PR avoids saying "MUST" because VC-SPECS-DIR is not meant to be the authoritative registry of everything VCs, but rather a directory of things that individuals wanted to have listed.Preview | Diff