-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Media Type Extensions" category. #14
Conversation
How does someone know that they need to add a "Media Type Extension"? How does one go about doing this? If added to this section/document or a W3C Registry or something else, do they also need to request to be registered with IANA? How does the draft section satisfy the requirements that will be described by the answers to the questions above? |
They feel it... in their bones. :P Maybe we should say something about this in this section? https://w3c.github.io/vc-data-model/#media-types
Same way they add any other specification entry to the vc-specs-dir: https://github.com/w3c/vc-specs-dir#adding-new-entries-to-the-directory
While it's not required, it would be a good idea to do so.
We could add some guidance at the top of that section... or we could point to the media types section in vc-data-model. I don't have any strong preferences here and would like others reviewing the PR to weigh in w/ some stronger opinions to indicate a desired direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to include the base media type here as well.
"summary": "Securing Verifiable Credentials using JSON Web Tokens.", | ||
"specification": "https://w3c.github.io/vc-jwt/", | ||
"category": "media-type", | ||
"maintainerEmail": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a "tranformationDirectionality" field to capture the uni/bidirectional nature of the media type transformation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that people would note that in the description, though, you're right -- if specifying the directionality is a requirement for VC-associated media types, then perhaps it should be a field.
I'd prefer if we got to consensus on exactly what these "transformation rules" need to do/say about directionality before adding that field to the registration requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us not add another property, let us use the convention of commenting on this in the description.
The spec that is referenced should do the work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The less we say about "transformation rules" the better.
The important part is that the output conform to application/vc+ld+json
... how you get there is the business of the spec that is registered here. The VCWG's business is in ensuring that the output matches the expected media type.
Also, as I have said elsewhere, there can be more than 1 mapping... this is not our change to make 3 rings for the elves.
I also don't want the working group dragged into "reviewing mappings"... that is the entire point of the day 3 resolution, to shift that burden to the implementer, and give them a clear way to tell if they did a good job (does the output of your mapping look like application/vc+ld+json
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is so stale it no longer reflects the working group documents, I have suggested changes to correct it.
I think it is worth relating this to w3c/vc-data-model#1048 and having the media types section direct people to here as well, I'll be opening a pr with hopefully text doing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems premature, given the requirements for mappings floating around:
I suggest we get consensus on requirements before proceeding.
I am more than a little concerned that this feels like a competitor to IANA registration, with little to no gatekeeping, especially as compared to IANA. |
The issue was discussed in a meeting on 2023-04-12
View the transcript3.2. Add "Media Type Extensions" category. (pr vc-specs-dir#14)See github pull request vc-specs-dir#14. Manu Sporny: VC Specifications dir. PR for media extension vocab, and has had much conversation. An attemp to figure out ADCD, JWT and Gordian etc. Brent Zundel: so noted and will be brought up. |
The issue was discussed in a meeting on 2023-04-19
View the transcript3.1. Add "Media Type Extensions" category. (pr vc-specs-dir#14)See github pull request vc-specs-dir#14. Manu Sporny: Sure, the others are moving along, aren't super important. There's one -- let me call that out. There's a media types extension.
Manu Sporny: That's the only one that really jumps out at me. |
I suggest the PR be closed |
The issue was discussed in a meeting on 2023-06-14
View the transcript1.7. Add "Media Type Extensions" category. (pr vc-specs-dir#14)See github pull request vc-specs-dir#14. Manu Sporny: there is 1 pr to add a media types extensions category. joe: i think the notion of the directory, is that any related specs can go there... don't understand why its blocked. Manu Sporny: you are correct, the vc specs dir can have anything you want. joe: seems like we will have media types to related to vcs and schema.
joe: there are 4 open PRs for status lists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w3c/vc-jose-cose#88 removes vc+jwt
from the JWT-VC spec, so it does not have to be registered.
@Sakurann wrote:
I changed the PR to register |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need to register application/vc+ld+json, it's in VCDM and the only one usable with data integrity of JWT-VC specs. we do not need media types registry itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now blocking our ability to create clarity around :
vc+ld+jwt vs vc+jwt.
This PR should be merged, but expect the entry for vc-jwt to change to IETF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Orie Steele <[email protected]>
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application/vc+ld+json+jwt
is not used anywhere in VCDM 2.0 nor vc-jose-cose, which uses application/vc+ld+json
and application/vc+ld+jwt
.
@Sakurann -- Multiple threads of discussion about media types have split things. Conclusion in one of those other threads was that |
@Sakurann you are correct that there is a lot of cleanup that would need to be done, after this PR is merged.
We would also expect |
there already seems to be reluctance towards two structured suffixes in IETF and using three seems to make it acceptable even harder (also for the implementers who are mostly used to one structured suffixes). having said that, there seems to be an agreement on vc+ld+jwt+json.... so not blocking this. (I won't explicitly approve, but feel free to dismiss my request for changes). .......application/vc+ld+json+jwt+json and / or application/vc+ld+json+sd-jwt+json does not make much sense to me...... |
The issue was discussed in a meeting on 2023-08-09
View the transcript2.5. Refer to VC-SPECS-DIR for proof types. (pr vc-data-model#1212)See github pull request vc-data-model#1212. Manu Sporny: PR 1212 examples of securing mechanisms in spec. Point to specifications or directory? Need PR about media types? Orie Steele: VCs with some securing mechanisms, with DI proofs; two specs; or media types; This or that language in DM spec. Joe Andrieu: this establishes related specs into a privileged position...
Manu Sporny: securing mechanisms we have vetted here and those not. Anyone can add to specs dir. No review...
Manu Sporny: very dangerous thing; any mechanism...
Joe Andrieu: I think anything does go; people can come up with new crypto; a directory is okay; our mechanisms are published as recs. Sebastian Crane: be careful, don't devalue our (WG) opinion. Kristina Yasuda: safely change to MAY... Manu Sporny: we don't say what has/hasn't been vetted in registry? The VC DM doesn't say what has been vetted.
Manu Sporny: what sections/where to put? Orie Steele: if media types is merge is will be obvious;. See github pull request vc-specs-dir#14.
Manu Sporny: blocking on Kristina PR 14; create media type in specs dir; then merge.
Joe Andrieu: avoid that directory is a registry.
See github issue vc-specs-dir#27. |
Noting that @Sakurann unblocked this PR over here in this comment: w3c/vc-data-model#1212 (comment) |
Substantive, multiple reviews, changes requested and made, no remaining objections, merging. |
This PR adds a "Media Type Extensions" section, and an example of it's usage by adding the
application/vc+jwt
media type to the section. The result is a section that looks like this in the vc-specs-dir:This is an attempt to partially implement the resolution made at the 2023 Miami VCWG F2F Meeting and the tracking issue in vc-data-model: w3c/vc-data-model#1048
Preview | Diff