Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Potential Evaluation Errors #1553

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Resolving Potential Evaluation Errors #1553

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f428eeb
Resolve potential division by 0 in ASM1 R7
MarcusHolly Jan 23, 2025
dccb997
Remove potential 0 division in CSTR
MarcusHolly Jan 23, 2025
ab58095
Fix 0 division in MCAS
MarcusHolly Jan 23, 2025
408f2a0
Resolve cstr_injection division by 0
MarcusHolly Jan 23, 2025
ed05efb
Resolve 0 divisions and non-positive logs in AD
MarcusHolly Jan 24, 2025
2a9cfef
Address BSM2 potential evaluation errors
MarcusHolly Jan 30, 2025
4c8eb40
Merge branch 'main' into mcas_scaling
MarcusHolly Jan 30, 2025
1fb3878
Address Pylint issue
MarcusHolly Jan 30, 2025
95d610f
Minor change to BSM2-P flowsheet
MarcusHolly Jan 30, 2025
93ba87a
Address BSM2-P potential evaluation errors
MarcusHolly Jan 31, 2025
c0969f1
Resolve potential divisions by zero in prop packs
MarcusHolly Jan 31, 2025
21d22b2
Resolve test failures in dye desal
MarcusHolly Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve cstr_injection division by 0
  • Loading branch information
@MarcusHolly
MarcusHolly committed Jan 23, 2025
commit 408f2a0e395fa474705e866a7bec5b2fce347dee
5 changes: 3 additions & 2 deletions watertap/unit_models/cstr_injection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,9 @@ def cstr_performance_eqn(b, t, r):
)
def eq_hydraulic_retention_time(self, t):
return (
self.hydraulic_retention_time[t]
== self.volume[t] / self.control_volume.properties_in[t].flow_vol
self.volume[t]
== self.hydraulic_retention_time[t]
* self.control_volume.properties_in[t].flow_vol
)

if self.config.has_aeration:
Expand Down