ci: migrate open source licensing pipeline to a different Concourse URL #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2023 15:06
| fly -t "${TARGET}" order-pipelines --alphabetical > /dev/null |
There was a problem hiding this comment.
nit: would be good to add an empty line here so git doesn't complain
| branch: main | ||
| - name: wavefront-sdk-go | ||
| type: git | ||
| source: | ||
| uri: [email protected]:wavefrontHQ/wavefront-sdk-go | ||
| branch: main | ||
| private_key: ((tas2to-osspi.github-private-key)) | ||
| private_key: ((tas2to.github-private-key)) |
There was a problem hiding this comment.
nit: it would be nice to give the go sdk its own set of secrets
LukeWinikates
suggested changes
Oct 23, 2023
| fly -t runway sync || ( | ||
| echo "This requires the runway target to be set" | ||
| echo "Create this target by running 'fly -t runway login -c https://runway-ci.eng.vmware.com -n tobs-k8s-group'" | ||
| echo "Create this target by running 'fly -t "${TARGET}" login -c https://runway-ci-sfo.eng.vmware.com -n cpo-team-troll'" |
There was a problem hiding this comment.
change request: how about we create a new runway group just for the Wavefront SDKs?
|
question: Can we also create a new private repo for these internal concourse pipelines, and store them there instead? |
|
Thanks for all of the feedback, @LukeWinikates! I'll look at this later today. |
|
for reference, here's what the java/python SDKs' osspi pipelines look like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.