Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate open source licensing pipeline to a different Concourse URL #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/pipelines/osspi-wavefront-sdk-go/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ resources:
icon: gitlab
source:
uri: [email protected]:source-insight-tooling/norsk-to-osspi.git
private_key: ((tas2to-osspi.norsk-to-osspi-private-key))
private_key: ((tas2to.norsk-to-osspi-private-key))
branch: main
- name: wavefront-sdk-go
type: git
source:
uri: [email protected]:wavefrontHQ/wavefront-sdk-go
branch: main
private_key: ((tas2to-osspi.github-private-key))
private_key: ((tas2to.github-private-key))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be nice to give the go sdk its own set of secrets


jobs:
- name: wavefront-sdk-go-scan
Expand All @@ -32,8 +32,8 @@ jobs:
params:
REPO: repo2
OSM_ENVIRONMENT: ((osm-environment))
API_KEY: ((tas2to-osspi.apikey-((osm-environment))))
USERNAME: ((tas2to-osspi.user-((osm-environment))))
API_KEY: ((tas2to.apikey-((osm-environment))))
USERNAME: ((tas2to.user-((osm-environment))))
PRODUCT: wavefront-sdk-go
VERSION: ((version))
OSM_PACKAGE_GROUP_NAME: wavefront-sdk-go
Expand Down
11 changes: 6 additions & 5 deletions ci/pipelines/osspi-wavefront-sdk-go/set_pipeline.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ set -efuo pipefail

which fly || (
echo "This requires fly to be installed"
echo "Download the binary from https://github.com/concourse/concourse/releases or from the Runway Concourse: https://runway-ci.eng.vmware.com"
echo "Download the binary from https://github.com/concourse/concourse/releases or from the Runway Concourse: https://runway-ci-sfo.eng.vmware.com"
exit 1
)

TARGET=runway-sfo
fly -t runway sync || (
echo "This requires the runway target to be set"
echo "Create this target by running 'fly -t runway login -c https://runway-ci.eng.vmware.com -n tobs-k8s-group'"
echo "Create this target by running 'fly -t "${TARGET}" login -c https://runway-ci-sfo.eng.vmware.com -n cpo-team-troll'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change request: how about we create a new runway group just for the Wavefront SDKs?

exit 1
)

Expand All @@ -18,10 +19,10 @@ VERSION=${VERSION:-"Latest"}
OSM_ENVIRONMENT=${OSM_ENVIRONMENT:-"production"}
echo "using OSM_ENVIRONMENT: ${OSM_ENVIRONMENT}. Valid environments are beta and production"

fly --target runway set-pipeline \
--pipeline "osspi-wavefront-sdk-go" \
fly --target "${TARGET}" set-pipeline \
--pipeline "wavefront-sdk-go-osspi" \
--config "${pipeline_dir}/pipeline.yml" \
--var osm-environment="${OSM_ENVIRONMENT}" \
--var version="${VERSION}"

fly -t runway order-pipelines --alphabetical > /dev/null
fly -t "${TARGET}" order-pipelines --alphabetical > /dev/null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be good to add an empty line here so git doesn't complain