🚩 Upgrade to NextJS v15 #375

shubhamkhan · 2024-10-25T16:45:27Z

Application NextJS Upgrade to v15

This pull request upgrades the Next.js framework from the previous version to v15.
Please review the changes, and let me know if you have any questions or feedback.

Application NextJS Upgrade to v15

changeset-bot · 2024-10-25T16:45:30Z

🦋 Changeset detected

Latest commit: d1292c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
socialify	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2024-10-25T16:45:30Z

👷 Deploy request for github-socialify pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`d1292c8`

wei

Thanks for opening the PR! Please follow the full NextJS 15 upgrade guide which includes upgrading to React 19.

Please review all the framework features and make adjustments to the app as needed.

Please recommend future improvements that can be adopted for NextJS after the initial upgrade.

Upgrade to React Js v19

shubhamkhan · 2024-10-26T02:38:44Z

Hi @wei, I have upgrade to React v19 with dependencies.

wei

hello we're still missing these two items from the last review:

Please review all the framework features and make adjustments to the app as needed.
Please recommend future improvements that can be adopted for NextJS after the initial upgrade.

Could you comment on any new features or changes nextjs and react 19 brings that we should adopt or could benefit from in the project? Thank you!

btw also missing changeset file as seen in the first comment by changeset bot.

wei · 2024-10-26T04:34:27Z

package.json

@@ -6,7 +6,7 @@
  "license": "MIT",
  "repository": "https://github.com/wei/socialify.git",
  "scripts": {
-    "dev": "next dev",
+    "dev": "next dev --turbopack",


can you explain this change or link to the source?

Turbopack I have used for incremental bundler optimized for JavaScript and TypeScript in Next.js and faster local development

Thanks I see the blogpost at https://nextjs.org/blog/turbopack-for-development-stable is using --turbo but your change is --turbopack. Do you have documentation on the difference?

Hi @wei, the --turbo flag was initially used when Turbopack was in its experimental phase. Now, --turbopack is stable and recommended for activating Turbopack in Next.js.

Main article: Turbopack for Development -> Turbo Engine: Core Concepts -> Getting Started: Turbo Documentation

Thank you!

@shubhamkhan could you respond to my comment above?

wei · 2024-10-26T04:35:06Z

package.json

@@ -71,5 +71,5 @@
      "last 1 firefox version",
      "last 1 safari version"
    ]
-  }
+  }  


Please run linter before committing.

Sure, I will do.

Hey @shubhamkhan This is not yet resolved ^

Changeset added

shubhamkhan · 2024-10-26T18:53:41Z

Hi @wei,

Added a changeset to document the updates.
Ensured code consistency with linting and ran tests successfully.

wei · 2024-10-27T04:56:56Z

Hello, thanks for the update, however, we're still missing these items from the last review:

Please review all the framework features and make adjustments to the app as needed.

Please recommend future improvements that can be adopted for NextJS after the initial upgrade.

Could you comment on any new features or changes nextjs and react 19 brings that we should adopt or could benefit from in the project? Thank you!

Please click re-request review once these points have been addressed.

wei

Please address previous outstanding comments. Thank you!

Review and implement NextJS and React features

Review and Implement NextJS and React features

shubhamkhan · 2024-10-29T20:40:13Z

Hi @wei, Please check Review and implement of Next.js and React features. Thanks you!

wei · 2024-10-30T01:23:45Z

Great! Please check outstanding comments above (I tagged you again in case you missed it)

Please list out all the changes you have implemented with source links so we can get them fully reviewed and approved.

Thank you!

wei · 2024-10-30T01:26:45Z

src/components/mainWrapper.tsx

-    if (!response || !response.repository) {
+    if (!response) {
+      return
+    }


Any reason to no longer redirect when response is falsy?

wei · 2024-10-30T01:27:27Z

src/components/toaster.tsx

+          className={`alert ${className} w-fit shadow-lg`}
+          role="alert"
+          aria-live="polite"
+          aria-atomic="true"


What are these for? Could you link me the sources?

wei · 2024-10-30T01:27:52Z

pages/index.tsx

+    <>
+      <Repo />
+    </>
+  )


Any reason for this change?

For maintaining coding structure

wei · 2024-10-30T01:28:15Z

pages/api/graphql.ts

@@ -20,6 +20,7 @@ const graphQLEndpoint = async (req: NextRequest) => {
      'content-type': 'application/json',
    },
    body: req.body,
+    cache: 'force-cache',


How does cache behave with POST requests? Could you help me understand? TY!

Review change to remove code

shubhamkhan

Hi @wei, Can you review the updated code and validate, I run lint and test before commit. Thank You!

shubhamkhan · 2024-10-26T08:07:45Z

package.json

@@ -71,5 +71,5 @@
      "last 1 firefox version",
      "last 1 safari version"
    ]
-  }
+  }  


Sure, I will do.

shubhamkhan · 2024-10-29T18:32:05Z

package.json

@@ -6,7 +6,7 @@
  "license": "MIT",
  "repository": "https://github.com/wei/socialify.git",
  "scripts": {
-    "dev": "next dev",
+    "dev": "next dev --turbopack",


Hi @wei, the --turbo flag was initially used when Turbopack was in its experimental phase. Now, --turbopack is stable and recommended for activating Turbopack in Next.js.

Main article: Turbopack for Development -> Turbo Engine: Core Concepts -> Getting Started: Turbo Documentation

Thank you!

shubhamkhan · 2024-10-30T02:46:19Z

pages/index.tsx

+    <>
+      <Repo />
+    </>
+  )


For maintaining coding structure

🚩 Upgrade to NextJS 15

490ddae

Application NextJS Upgrade to v15

wei requested changes Oct 25, 2024

View reviewed changes

wei linked an issue Oct 25, 2024 that may be closed by this pull request

Upgrade to Next.js 15 #373

Open

⬆️ Upgrade React19

4cad4d6

Upgrade to React Js v19

wei requested changes Oct 26, 2024

View reviewed changes

📌 Upgrade dependencies changeset added

4a12586

Changeset added

shubhamkhan requested a review from wei October 27, 2024 07:53

wei requested changes Oct 29, 2024

View reviewed changes

shubhamkhan added 2 commits October 29, 2024 20:18

🎨 Review and implement NextJS and React features

abead08

Review and implement NextJS and React features

🎨 Review and Implement NextJS and React features

6a924e1

Review and Implement NextJS and React features

shubhamkhan requested a review from wei October 29, 2024 20:40

wei reviewed Oct 30, 2024

View reviewed changes

🔥 Review change

d1292c8

Review change to remove code

shubhamkhan commented Oct 30, 2024

View reviewed changes

shubhamkhan requested a review from wei October 30, 2024 13:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚩 Upgrade to NextJS v15 #375

🚩 Upgrade to NextJS v15 #375

shubhamkhan commented Oct 25, 2024

changeset-bot bot commented Oct 25, 2024 •

edited

Loading

netlify bot commented Oct 25, 2024 •

edited

Loading

wei left a comment •

edited

Loading

shubhamkhan commented Oct 26, 2024

wei left a comment •

edited

Loading

wei Oct 26, 2024

shubhamkhan Oct 26, 2024

wei Oct 27, 2024

shubhamkhan Oct 29, 2024

wei Oct 30, 2024

wei Oct 26, 2024

shubhamkhan Oct 26, 2024

wei Oct 30, 2024

shubhamkhan commented Oct 26, 2024

wei commented Oct 27, 2024

wei left a comment

shubhamkhan commented Oct 29, 2024

wei commented Oct 30, 2024

wei Oct 30, 2024

wei Oct 30, 2024

wei Oct 30, 2024

shubhamkhan Oct 30, 2024

wei Oct 30, 2024

shubhamkhan left a comment

shubhamkhan Oct 26, 2024

shubhamkhan Oct 29, 2024

shubhamkhan Oct 30, 2024

🚩 Upgrade to NextJS v15 #375

Are you sure you want to change the base?

🚩 Upgrade to NextJS v15 #375

Conversation

shubhamkhan commented Oct 25, 2024

Application NextJS Upgrade to v15

changeset-bot bot commented Oct 25, 2024 • edited Loading

🦋 Changeset detected

netlify bot commented Oct 25, 2024 • edited Loading

👷 Deploy request for github-socialify pending review.

wei left a comment • edited Loading

Choose a reason for hiding this comment

shubhamkhan commented Oct 26, 2024

wei left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubhamkhan commented Oct 26, 2024

wei commented Oct 27, 2024

wei left a comment

Choose a reason for hiding this comment

shubhamkhan commented Oct 29, 2024

wei commented Oct 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubhamkhan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 25, 2024 •

edited

Loading

netlify bot commented Oct 25, 2024 •

edited

Loading

wei left a comment •

edited

Loading

wei left a comment •

edited

Loading