-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚩 Upgrade to NextJS v15 #375
base: master
Are you sure you want to change the base?
Changes from all commits
490ddae
4cad4d6
4a12586
abead08
6a924e1
d1292c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"socialify": minor | ||
--- | ||
|
||
Upgrade Next.js to v15, React to v19, and update related dependencies |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
"license": "MIT", | ||
"repository": "https://github.com/wei/socialify.git", | ||
"scripts": { | ||
"dev": "next dev", | ||
"dev": "next dev --turbopack", | ||
"debug": "NODE_OPTIONS='--inspect' next", | ||
"build": "next build", | ||
"test": "jest", | ||
|
@@ -22,7 +22,7 @@ | |
"prepare": "is-ci || husky" | ||
}, | ||
"dependencies": { | ||
"@changesets/cli": "^2.27.8", | ||
"@changesets/cli": "^2.27.9", | ||
"@resvg/resvg-wasm": "^2.6.2", | ||
"autoprefixer": "^10.4.20", | ||
"badgen": "^3.2.3", | ||
|
@@ -31,31 +31,31 @@ | |
"daisyui": "^2.46.1", | ||
"hero-patterns": "^2.1.0", | ||
"is-ci": "^3.0.1", | ||
"next": "^14.2.8", | ||
"postcss": "^8.4.45", | ||
"react": "^18.3.1", | ||
"react-dom": "^18.3.1", | ||
"react-error-boundary": "^4.0.13", | ||
"next": "^15.0.1", | ||
"postcss": "^8.4.47", | ||
"react": "19.0.0-rc-69d4b800-20241021", | ||
"react-dom": "19.0.0-rc-69d4b800-20241021", | ||
"react-error-boundary": "^4.1.2", | ||
"react-hot-toast": "^2.4.1", | ||
"react-icons": "^5.3.0", | ||
"satori": "^0.10.14", | ||
"simple-icons": "^11.13.0", | ||
"styled-jsx": "^5.1.6", | ||
"tailwindcss": "^3.4.10", | ||
"typescript": "~5.5.4", | ||
"use-debounce": "^10.0.3", | ||
"tailwindcss": "^3.4.14", | ||
"typescript": "~5.6.3", | ||
"use-debounce": "^10.0.4", | ||
"yoga-wasm-web": "^0.3.3" | ||
}, | ||
"devDependencies": { | ||
"@biomejs/biome": "^1.8.3", | ||
"@biomejs/biome": "^1.9.4", | ||
"@testing-library/dom": "^10.4.0", | ||
"@testing-library/jest-dom": "^6.5.0", | ||
"@testing-library/jest-dom": "^6.6.2", | ||
"@testing-library/react": "^16.0.1", | ||
"@types/jest": "^29.5.12", | ||
"@types/react": "18.3.5", | ||
"@types/jest": "^29.5.14", | ||
"@types/react": "18.3.12", | ||
"graphql": "^16.9.0", | ||
"graphql-compiler": "^1.7.0", | ||
"husky": "^9.1.5", | ||
"husky": "^9.1.6", | ||
"identity-obj-proxy": "^3.0.0", | ||
"jest": "^29.7.0", | ||
"jest-environment-jsdom": "^29.7.0" | ||
|
@@ -71,5 +71,5 @@ | |
"last 1 firefox version", | ||
"last 1 safari version" | ||
] | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please run linter before committing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, I will do. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey @shubhamkhan This is not yet resolved ^ |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
import MainRenderer from '../../src/components/mainRenderer' | ||
|
||
const RepoPage = () => { | ||
return <MainRenderer /> | ||
return ( | ||
<> | ||
<MainRenderer /> | ||
</> | ||
) | ||
} | ||
|
||
export default RepoPage |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,4 +41,6 @@ export const config = { | |
runtime: 'edge', | ||
} | ||
|
||
export const fetchCache = 'default-cache' | ||
|
||
export default pngEndpoint |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,4 +43,6 @@ export const config = { | |
runtime: 'edge', | ||
} | ||
|
||
export const fetchCache = 'default-cache' | ||
|
||
export default svgEndpoint |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
import Repo from '../src/components/repo/repo' | ||
|
||
const HomePage = () => { | ||
return <Repo /> | ||
return ( | ||
<> | ||
<Repo /> | ||
</> | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason for this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For maintaining coding structure |
||
} | ||
|
||
export default HomePage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain this change or link to the source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turbopack I have used for incremental bundler optimized for JavaScript and TypeScript in Next.js and faster local development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I see the blogpost at https://nextjs.org/blog/turbopack-for-development-stable is using
--turbo
but your change is--turbopack
. Do you have documentation on the difference?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wei, the
--turbo
flag was initially used when Turbopack was in its experimental phase. Now,--turbopack
is stable and recommended for activating Turbopack in Next.js.Main article: Turbopack for Development -> Turbo Engine: Core Concepts -> Getting Started: Turbo Documentation
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhamkhan could you respond to my comment above?