chore: bring back architecture test after being ignored #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
Garzas and
saleniuk
and removed request for
a team
vitorhugods
approved these changes
Jan 30, 2024
alexandreferris
approved these changes
Jan 30, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2746 Passed, 136 Skipped, 8m 38s Wall Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2431 +/- ##
====================================================
Coverage ? 57.98%
Complexity ? 21
====================================================
Files ? 1166
Lines ? 45019
Branches ? 4229
====================================================
Hits ? 26105
Misses ? 17032
Partials ? 1882 Continue to review full report in Codecov by Sentry.
|
6 tasks
mchenani
pushed a commit
that referenced
this pull request
Feb 7, 2024
(cherry picked from commit dd93987)
yamilmedina
added a commit
that referenced
this pull request
Feb 7, 2024
* chore: bring back architecture test after being ignored (#2431) * Empty-Commit * remove un-needed changes * chore: reenable test --------- Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]>
augustocdias
pushed a commit
that referenced
this pull request
Feb 13, 2024
* chore: bring back architecture test after being ignored (#2431) * Empty-Commit * remove un-needed changes * chore: reenable test --------- Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Architecture tests are ignored
Causes (Optional)
Circular dependencies, and other code smells, are not being caught.
Solutions
Renable, and supress (for now) failed tests.
Testing
Test Coverage (Optional)
Notes (Optional)
Tickets are going to be created as tech debt to be solved, at least for develop as a last resort.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.