Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): get my clients state (WPB-6345) #2436

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Getting mlsSelfConversation ID was not covered in getting the current client identities.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

After:
Wire 2024-01-31 at 11_01 AM

Before:
image


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Test Results

2 770 tests   2 642 ✔️  25s ⏱️
   481 suites     128 💤
   481 files           0

Results for commit 96b4d48.

♻️ This comment has been updated with latest results.

Base automatically changed from release/fix/e2ei/fix-e2ei-enrollment to release/candidate February 1, 2024 10:58
@mchenani mchenani enabled auto-merge (squash) February 1, 2024 11:32
@datadog-wireapp
Copy link

Datadog Report

Branch report: release/fix/e2ei/get-my-cleints-certs
Commit report: 30417fa
Test service: kalium-jvm

✅ 0 Failed, 2766 Passed, 122 Skipped, 8m 52.07s Wall Time

@mchenani mchenani merged commit 00a3b74 into release/candidate Feb 1, 2024
17 checks passed
@mchenani mchenani deleted the release/fix/e2ei/get-my-cleints-certs branch February 1, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants