-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): get my clients state (WPB-6345) #2436
Merged
mchenani
merged 6 commits into
release/candidate
from
release/fix/e2ei/get-my-cleints-certs
Feb 1, 2024
Merged
fix(e2ei): get my clients state (WPB-6345) #2436
mchenani
merged 6 commits into
release/candidate
from
release/fix/e2ei/get-my-cleints-certs
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchenani
requested review from
typfel,
borichellow,
MohamadJaara and
ohassine
January 31, 2024 15:30
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: XXL
labels
Jan 31, 2024
mchenani
changed the base branch from
release/candidate
to
release/fix/e2ei/fix-e2ei-enrollment
January 31, 2024 15:33
borichellow
approved these changes
Jan 31, 2024
yamilmedina
approved these changes
Feb 1, 2024
Base automatically changed from
release/fix/e2ei/fix-e2ei-enrollment
to
release/candidate
February 1, 2024 10:58
Datadog ReportBranch report: ✅ 0 Failed, 2766 Passed, 122 Skipped, 8m 52.07s Wall Time |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Getting mlsSelfConversation ID was not covered in getting the current client identities.
Testing
Test Coverage (Optional)
Attachments (Optional)
After:
Before:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.