fix: changing profile avatar doesn't reflect update (WPB-5494) #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
requested review from
a team,
typfel,
borichellow,
MohamadJaara,
Garzas and
ohassine
and removed request for
a team
ohassine
approved these changes
Feb 2, 2024
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2443 +/- ##
====================================================
Coverage ? 58.29%
Complexity ? 21
====================================================
Files ? 1166
Lines ? 45024
Branches ? 4234
====================================================
Hits ? 26246
Misses ? 16894
Partials ? 1884 Continue to review full report in Codecov by Sentry.
|
MohamadJaara
reviewed
Feb 2, 2024
MohamadJaara
approved these changes
Feb 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* fix: remove SELECT changes from updateUser query * fix: add transactionWithResult when updateUser and return select changes * test: add tests for observing user details by id
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* fix: changing profile avatar doesn't reflect update (WPB-5494) (#2443) * fix: remove SELECT changes from updateUser query * fix: add transactionWithResult when updateUser and return select changes * test: add tests for observing user details by id * fix: add UPDATE OR FAIL to update query and remove select changes query as it is not used anymore * fix: remove unused select changes query and change return type of updateUser to Unit * fix: adjust existing tests --------- Co-authored-by: Alexandre Ferris <[email protected]>
augustocdias
pushed a commit
that referenced
this pull request
Feb 13, 2024
* fix: changing profile avatar doesn't reflect update (WPB-5494) (#2443) * fix: remove SELECT changes from updateUser query * fix: add transactionWithResult when updateUser and return select changes * test: add tests for observing user details by id * fix: add UPDATE OR FAIL to update query and remove select changes query as it is not used anymore * fix: remove unused select changes query and change return type of updateUser to Unit * fix: adjust existing tests --------- Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When changing user profile avatar it wasn't being reflected in other screens in the app
Causes (Optional)
the query
updateUserwas a transaction returningSELECT changes(), thus sqldelight not emitting the update on the table.Solutions
Remove transaction and
SELECT changes()from the query and addtransactionWithResulton the DAOImpl to properly reflect the changes upwards when needed.Testing
How to Test
Notes (Optional)
@vitorhugods opened an issue on SQLDelight : sqldelight/sqldelight#5001