Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unread archived conversations indicator [WPB-4437] #2288

Merged
merged 10 commits into from
Oct 2, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 28, 2023

StoryWPB-4437 Add an indicator on the archived tab


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added unread indicator for archived conversation drawer item

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
before after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Test Results

623 tests   622 ✔️  6m 45s ⏱️
  90 suites      1 💤
  90 files        0

Results for commit 889e6c4.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1053 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #2288 (889e6c4) into develop (b7d4c8d) will increase coverage by 0.07%.
Report is 2 commits behind head on develop.
The diff coverage is 93.75%.

@@              Coverage Diff              @@
##             develop    #2288      +/-   ##
=============================================
+ Coverage      40.42%   40.49%   +0.07%     
- Complexity      1014     1018       +4     
=============================================
  Files            318      320       +2     
  Lines          11696    11712      +16     
  Branches        1561     1561              
=============================================
+ Hits            4728     4743      +15     
- Misses          6520     6521       +1     
  Partials         448      448              
Files Coverage Δ
...com/wire/android/ui/home/drawer/HomeDrawerState.kt 100.00% <100.00%> (ø)
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 93.33% <93.33%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952180c...889e6c4. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1063 succeeded.

The build produced the following APK's:

Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a minor non blocking comment

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1068 succeeded.

The build produced the following APK's:

@Garzas Garzas enabled auto-merge October 2, 2023 07:13
@Garzas Garzas added this pull request to the merge queue Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 7884f76 Oct 2, 2023
@Garzas Garzas deleted the feat/unread-archived-conversations-indicator branch October 2, 2023 07:39
@AndroidBob
Copy link
Collaborator

Build 1086 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants