Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T345689 build three versions plain #478

Merged
merged 37 commits into from
Nov 1, 2023
Merged

T345689 build three versions plain #478

merged 37 commits into from
Nov 1, 2023

Conversation

rti
Copy link
Contributor

@rti rti commented Sep 21, 2023 •
edited
Loading

In this PR:

  • refactor the github action and build script to work similarily for every component (wikibase, wdqs, ...)
  • build wikibase (base) and wikibase-bundle with the same make target
  • combine github actions so that everything (lint, build, test, publish to GHCR) happens in one workflow

This was referenced Sep 26, 2023
Closed
Closed
@rti rti force-pushed the T345689-build-three-versions-plain branch from ad425f7 to 57d10c9 Compare September 26, 2023 08:53
@rti rti requested a review from a team September 26, 2023 14:22
@rti rti marked this pull request as ready for review September 26, 2023 14:22
RickiJay-WMDE
RickiJay-WMDE reviewed Sep 27, 2023
View reviewed changes
channels/lts.env Outdated Show resolved Hide resolved
@rti rti force-pushed the T345689-build-three-versions-plain branch from 6956770 to 661c4db Compare September 27, 2023 09:48
RickiJay-WMDE
RickiJay-WMDE reviewed Sep 27, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@rti rti requested review from adeeri and RickiJay-WMDE September 27, 2023 11:11
RickiJay-WMDE
RickiJay-WMDE previously approved these changes Oct 9, 2023
View reviewed changes
@rti rti requested review from a team and removed request for lorenjohnson and adeeri October 31, 2023 11:48
@rti rti dismissed RickiJay-WMDE’s stale review October 31, 2023 11:49

substancial changes made, re-review requested as part of new wmde/wikibase-suite group

lorenjohnson
lorenjohnson requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the two comments.

versions.env Outdated Show resolved Hide resolved
lorenjohnson
lorenjohnson approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Will merge and then do some additional testing of the Upgrade test.

.github/workflows/build_and_test.yml Show resolved Hide resolved
@lorenjohnson lorenjohnson merged commit 7686b1a into main Nov 1, 2023
@lorenjohnson lorenjohnson deleted the T345689-build-three-versions-plain branch November 1, 2023 13:59
@lorenjohnson lorenjohnson restored the T345689-build-three-versions-plain branch November 1, 2023 14:00
@RickiJay-WMDE RickiJay-WMDE deleted the T345689-build-three-versions-plain branch November 2, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeeri adeeri adeeri left review comments

@lorenjohnson lorenjohnson lorenjohnson approved these changes

@RickiJay-WMDE RickiJay-WMDE Awaiting requested review from RickiJay-WMDE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rti @lorenjohnson @adeeri @RickiJay-WMDE