-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T340226 reproducible builds #517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c45d3c6
to
e8a3947
Compare
e8a3947
to
d61d83d
Compare
26764e0
to
a9638fc
Compare
rti
commented
Dec 4, 2023
lorenjohnson
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So excited for this one. My favourite set of changes to date! I approve and based on use so far think its doing everything it should. 🎉
rti
added a commit
that referenced
this pull request
Dec 15, 2023
rti
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed in this PR
This PR became a bit more complex as it turned out to make lots of sense to do some of the "heavy lifting" tasks in the build system all at once instead of distributing them in several PRs.
Specifically, this PR changes:
variables.env
which should makes builds pretty™ reproducible, this is true for git checkouts and docker images https://phabricator.wikimedia.org/T340226Docker
folder https://phabricator.wikimedia.org/T343873./build.sh
now has a slightly different interface, see README https://phabricator.wikimedia.org/T345564❗ We probably want to backport this to 1.39 and 1.40
Open Questions