ossf lazy #35302
Merged
ossf lazy #35302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo-sts
bot
added
the
bincapz/blocking
octo-sts
bot
added
bincapz/pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fix for:
-Wl,-z,nowcauses nvidia-device-plugin to fail to load #34568This change will enable using "-fhardened -Wl,-z,lazy" however, it will not yet enable using "-specs openssf.spec -Wl,-z,lazy" will need to open a new bug report about that. Still this should unblock openssf-ication of the affected packages.
Note, checked that all existing packages that call this test pipeline do not regress with proposed change.
Example on how to use this in practice is shown at #35325 which does work locally and passes build + test (which i think is the original reproducer that triggered this). Note that package uses cgo, and thus CGO_CFLAGS and CGO_LDFLAGS should be used to affect the build.