Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve post-onboarding #2635

Merged

Conversation

@joemcgill joemcgill self-assigned this Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 65.2%. Comparing base (42335a1) to head (37dacee).
Report is 102 commits behind head on feature/2458-2459-2460-2509.

Files with missing lines Patch % Lines
...c/dashboard/summary-section/paid-features/index.js 16.7% 5 Missing ⚠️
js/src/dashboard/summary-section/index.js 66.7% 2 Missing ⚠️
...product-statistics/create-campaign-notice/index.js 77.8% 2 Missing ⚠️
src/Notes/SetupCampaignTwoWeeks.php 0.0% 2 Missing ⚠️
...src/components/paid-ads/asset-group/asset-group.js 0.0% 1 Missing ⚠️
...rd/summary-section/paid-campaign-promotion-card.js 0.0% 1 Missing ⚠️
...rd/summary-section/paid-features/free-ad-credit.js 50.0% 1 Missing ⚠️
src/Notes/CompleteSetup.php 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             feature/2458-2459-2460-2509   #2635     +/-   ##
===============================================================
+ Coverage                           65.2%   65.2%   +0.1%     
  Complexity                          4587    4587             
===============================================================
  Files                                804     806      +2     
  Lines                              24269   24274      +5     
  Branches                            1246    1242      -4     
===============================================================
+ Hits                               15814   15835     +21     
+ Misses                              8280    8267     -13     
+ Partials                             175     172      -3     
Flag Coverage Δ
js-unit-tests 62.5% <53.8%> (+0.4%) ⬆️
php-unit-tests 65.9% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/components/paid-ads/add-paid-campaign-button.js 73.3% <100.0%> (ø)
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% <ø> (ø)
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% <ø> (ø)
...-ads/budget-section/budget-recommendation/index.js 5.3% <ø> (ø)
...-program-button/edit-program-prompt-modal/index.js 10.0% <ø> (ø)
...e-card/program-toggle/pause-program-modal/index.js 14.3% <ø> (ø)
...emove-program-button/remove-program-modal/index.js 7.1% <ø> (ø)
...dashboard/campaign-creation-success-guide/index.js 71.4% <ø> (ø)
js/src/pages/create-paid-ads-campaign/index.js 10.0% <ø> (ø)
js/src/pages/edit-paid-ads-campaign/index.js 8.6% <ø> (ø)
... and 12 more

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@eason9487 eason9487 changed the title Feature/2460 google ads value prop Feature: Improve post-onboarding Nov 20, 2024
@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Nov 20, 2024
@joemcgill
Copy link
Collaborator Author

@eason9487 I've just opened #2683 to finish any final text tweaks that need to be made following from #2664. This should be merged prior to finalizing #2682.

…-tweaks

Improve post-onboarding: Update the budget recommendation text for campaign creation
@eason9487 eason9487 marked this pull request as ready for review November 21, 2024 03:27
Base automatically changed from feature/2459-campaign-creation-flow to feature/2458-2459-2460-2509 November 21, 2024 03:39
@eason9487 eason9487 merged commit 32adc37 into feature/2458-2459-2460-2509 Nov 21, 2024
16 checks passed
@eason9487 eason9487 deleted the feature/2460-google-ads-value-prop branch November 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Onboarding Overview
4 participants