Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline onboarding, post-onboarding and campaign setup #2682

Open
wants to merge 1,048 commits into
base: develop
Choose a base branch
from

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Nov 20, 2024

Changes proposed in this Pull Request:

This PR gathers all changes from the following feature PRs for final testing and to be merged together into develop.

📌 Checklist before merging

joemcgill and others added 30 commits October 31, 2024 07:44
Show promo for setting up Google Ads on the product feed tabs #2539
@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Nov 20, 2024
…oarding

Feature: Streamline the onboarding flow
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 55.30547% with 139 lines in your changes missing coverage. Please review.

Project coverage is 65.0%. Comparing base (5d03086) to head (f252968).

Files with missing lines Patch % Lines
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% 18 Missing and 3 partials ⚠️
...src/components/paid-ads/asset-group/asset-group.js 0.0% 13 Missing and 1 partial ⚠️
js/src/data/resolvers.js 22.2% 12 Missing and 2 partials ⚠️
js/src/hooks/useGoogleMCAccount.js 11.1% 6 Missing and 2 partials ⚠️
js/src/pages/create-paid-ads-campaign/index.js 0.0% 6 Missing and 1 partial ⚠️
js/src/pages/edit-paid-ads-campaign/index.js 0.0% 6 Missing and 1 partial ⚠️
js/src/utils/getHighestBudget.js 0.0% 5 Missing and 2 partials ⚠️
js/src/components/paid-ads/budget-section/index.js 16.7% 5 Missing ⚠️
...c/dashboard/summary-section/paid-features/index.js 16.7% 5 Missing ⚠️
js/src/setup-ads/ads-stepper/index.js 70.6% 5 Missing ⚠️
... and 24 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #2682     +/-   ##
===========================================
+ Coverage       64.7%   65.0%   +0.4%     
+ Complexity      4665    4656      -9     
===========================================
  Files            799     812     +13     
  Lines          24640   24572     -68     
  Branches        1242    1253     +11     
===========================================
+ Hits           15938   15983     +45     
+ Misses          8529    8417    -112     
+ Partials         173     172      -1     
Flag Coverage Δ
js-unit-tests 62.3% <54.5%> (-0.1%) ⬇️
php-unit-tests 65.8% <75.0%> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nts/free-ad-credit/country-modal/country-amount.js 100.0% <ø> (ø)
...c/components/free-ad-credit/country-modal/index.js 16.7% <ø> (ø)
js/src/components/free-ad-credit/index.js 11.1% <ø> (ø)
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
...gle-ads-account-card/connect-ads/connect-button.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/connect-ads/index.js 95.8% <100.0%> (-0.2%) ⬇️
.../components/google-combo-account-card/constants.js 100.0% <100.0%> (ø)
...components/merchant-center-select-control/index.js 100.0% <100.0%> (ø)
...rc/components/paid-ads/add-paid-campaign-button.js 73.3% <100.0%> (ø)
... and 56 more

... and 16 files with indirect coverage changes

---- 🚨 Try these New Features:

…fic scenario when connecting Google Merchant Center account.


Ref: #2660 (comment)
Consolidate accounts onboarding: Add edit mode to the combo card to enable it to disconnect accounts
…-tweaks

Improve post-onboarding: Update the budget recommendation text for campaign creation
…ion-flow

Feature: Streamline the campaign setup
…ogle-account-cards

Feature: Consolidate Google accounts setup during onboarding
…ue-prop

Feature: Improve post-onboarding
@eason9487
Copy link
Member Author

During overall testing, found an issue that it may try to connect to an unclaimed and disconnected account ID. Created PR #2688 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants