-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ECE Payment buttons on Pay for Order page #3440
Merged
Merged
Changes from 77 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
7d1d4b7
add ece feature flag
Mayisha a5cc1f0
update '@stripe/react-stripe-js' to latest
Mayisha 26c0196
render ece button on block checkout
Mayisha fe572d5
display ece button if feature flag is enabled
Mayisha 48e7e11
Merge branch 'develop' into task/3402-ece-ff
Mayisha 122db02
check ece feature flag status from blocks data
Mayisha 6a8e7ae
add min height to express checkout container
Mayisha 34dc409
create 'WC_Stripe_Express_Checkout_Element' class
Mayisha ac13e24
fix callback function name
Mayisha 0da1b05
register script for shortcode checkout
Mayisha 9291021
move ajax functions to separate class
Mayisha 8c6f05d
move helper functions to a separate class
Mayisha e3f68d3
include and initialize express checkout classes
Mayisha 9502a5a
Merge branch 'develop' into task/ece-backend
Mayisha 55e661c
make functions public in the helper class
Mayisha 08c3205
fix lint issue
Mayisha 7539f73
Merge branch 'develop' into task/ece-backend
Mayisha 1f42347
use correct global variable
Mayisha 632b63c
fix php lint issues
Mayisha 1be4921
Integrating ECE to shortcode checkout
wjrosa f2b64f3
Adding extra contraints to show ECE
wjrosa 1e901c9
Merge branch 'develop' into add/ece-for-shortcode-checkout
wjrosa b318c26
Importing additional implementations from WCPay
wjrosa 8956e8e
Use our own Stripe tracking
mattallan 0af7c3e
Fix typos in normalizeOrderData
mattallan acc8e92
Add missing client/api methods to handle ECE requests
mattallan afbb84e
Update ESLint config to not require await directly within async funct…
mattallan 0cd28d5
Fix JS linting issues
mattallan d94bde5
Use startExpressCheckoutElement() to init the payment button
james-allan 56225b3
Add getExpressCheckoutAjaxURL util function
mattallan 9a40a5d
Update ECE API functions to use express checkout data
mattallan 942af31
Move api const to top and add init function for page specific initial…
james-allan 3efecab
Fix comment
james-allan 08b7718
Localize scripts for pay for order screen and init payment element
james-allan 3a24788
Adding changelog entry
wjrosa c07f00d
Putting display none back
wjrosa 8244cf3
Multiple changes to the display logic based on WCPay
wjrosa 99cceb4
Multiple changes to the display logic based on WCPay
wjrosa b894df0
Fix multiple issues + changing the main element ID
wjrosa ef6f49d
Removing unsupported coalesce operator
wjrosa 1114804
Including missing methods
wjrosa d0055ea
Fix lint issues
wjrosa eeee466
Fix lint issues
wjrosa bc581aa
Updating ESLint version and requirement
wjrosa e839cd0
ECE instantiation options update
wjrosa 2c01b39
Process Express payment button payments via Pay for Order page
james-allan bd7dacd
Fix get/update shipping option AJAX requests
mattallan 1168099
Rename WooPayment related funtion and fix camelcase issue
james-allan a933b6e
Fetch proper requestShipping meta from product data
mattallan e49eb3a
Set 'wc-stripe-is-deferred-intent' in data submitted with the checkou…
mattallan 710df89
Set the wc-stripe-is-deferred-intent flag via the request, not the ha…
james-allan 03ecb97
Use camel case variable to avoid linting ignores
james-allan b204302
Remove eslint diable for camelcase
james-allan e36f28b
Merge branch 'develop' into add/ece-for-shortcode-checkout
wjrosa 1e08089
Fixing additional JS error + reverting removal of ESLint rule
wjrosa dbee822
Resolving ESLint issues
wjrosa a3409f9
Increasing ECMAScript version in .jshintrc
wjrosa 15ed41f
Reverting unnecessary changes to stripe-utils
wjrosa fe64a45
Reverting more unnecessary changes
wjrosa 63ba605
Reverting hardcoded flag
wjrosa 74df4cf
Fix Jest functions undefined in .jshintrc
wjrosa c0f2336
Adding specific unit tests
wjrosa bc7a79b
Adding specific unit tests
wjrosa 94b9c63
Reverting unnecessary changes
wjrosa 1554796
Putting some coalesce operators back
wjrosa a5b19e4
Replace i18n text domain
james-allan 7a53b7c
Fix typo
james-allan 584252f
Merge branch 'add/ece-for-shortcode-checkout' into add/ece-for-pay-fo…
james-allan 299d422
Merge branch 'develop' into add/ece-for-pay-for-order-page
james-allan 5c99912
Set deferred-intent flag
james-allan d9e80a8
Remove merge conflict flags
james-allan 53a8d2d
Remove unused files
james-allan 371649e
Add changelog entries
james-allan 8f91625
Merge branch 'develop' into add/ece-for-pay-for-order-page
james-allan fd8281e
Reintroduce changelog removed by error
james-allan 1236826
Fix button width issues
james-allan d30566a
Use tabs and add empty line
james-allan d9b9149
Merge branch 'develop' into add/ece-for-pay-for-order-page
mattallan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#wc-stripe-express-checkout-element iframe { | ||
max-width: unset; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,7 +130,8 @@ If you get stuck, you can ask for help in the Plugin Forum. | |
|
||
= 8.8.0 - xxxx-xx-xx = | ||
* Add - Implemented the "Update all subscriptions payment methods" checkbox on My Account → Payment methods for UPE payment methods. | ||
* Add - Add support for the new Stripe Checkout Element on the shortcode checkout page. | ||
* Add - Add support for the new Stripe Checkout Element on the shortcode checkout page. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is just a blank space at the end of the line which is being removed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Weird that GH isn't showing the whitespace being removed! |
||
* Add - Add support for the new Stripe Checkout Element on the pay for order page. | ||
* Dev - Introduces a new class with payment methods constants. | ||
* Dev - Introduces a new class with currency codes constants. | ||
* Dev - Improves the readability of the redirect URL generation code (UPE). | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an issue on all shortcode powered pages and follows the same approach WooPayments took in Automattic/woocommerce-payments#9094 and discussed with Stripe internallly here: p1720833500937719-slack-C9976E5MJ
PAY FOR ORDER
Gap on the right hand side of the payment elements.
CHECKOUT
CART