-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ECE Payment buttons on Pay for Order page #3440
Conversation
@@ -130,7 +130,8 @@ If you get stuck, you can ask for help in the Plugin Forum. | |||
|
|||
= 8.8.0 - xxxx-xx-xx = | |||
* Add - Implemented the "Update all subscriptions payment methods" checkbox on My Account → Payment methods for UPE payment methods. | |||
* Add - Add support for the new Stripe Checkout Element on the shortcode checkout page. | |||
* Add - Add support for the new Stripe Checkout Element on the shortcode checkout page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is just a blank space at the end of the line which is being removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that GH isn't showing the whitespace being removed!
@@ -0,0 +1,3 @@ | |||
#wc-stripe-express-checkout-element iframe { | |||
max-width: unset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an issue on all shortcode powered pages and follows the same approach WooPayments took in Automattic/woocommerce-payments#9094 and discussed with Stripe internallly here: p1720833500937719-slack-C9976E5MJ
PAY FOR ORDER
Gap on the right hand side of the payment elements.
CHECKOUT
CART
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really well put together PR @james-allan ! 💯
I've performed code review and the changes look good.
I've also tested the following flows/cases:
- Paying for an order with virtual/downloadable products
- Paying for an order with various shipping & tax totals
- Paying for an order with/without prices includes tax
- Paying for an order with discounts applied
- Paying for an order with multiple products
- Paying for an order with mix of variable/simple products
- Confirm orders have correct payment method title
- Order under minimum amount (0.20). Confirmed buttons don’t show.
- Test Apple Pay and Google Pay
Something I noticed is the Pay for Order doesn't add the quantity label like we do for the product page.
I.e.
Pay for Order | Product Page |
---|---|
This is a very minor detail and I noticed WooPayments does the same thing so happy to run with it as is.
oh neat. I'll file a separate issue for this because I think that's a good enhancement. |
Closes #3411
Changes proposed in this Pull Request:
This PR adds support for processing Express payment button payments via the Pay for Order page.
Google Pay and Apple Pay buttons on the Pay for Order
Testing instructions
SETUP
_wcstripe_feature_ece
option. SeeWC_Stripe_Feature_Flags::is_stripe_ece_enabled()
PAYMENTS
changelog.txt
andreadme.txt
(or does not apply)Post merge