Fix prb not loading in legacy checkout experience #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Nice fix! Works as expected:
New checkout experience.
- Enable the ECE feature flag. Confirm that on the checkout page, the ECE buttons are loaded and checkout with ECE is successful.
- Disable the ECE feature flag. Confirm that on the checkout page, the PRB buttons are loaded and checkout with PRB is successful.
Legacy checkout experience.
- Enable the ECE feature flag (because it is enabled by default now). Confirm that on the checkout page, the PRB buttons are loaded and checkout with PRB is successful.
Mayisha
force-pushed
the
fix/3645-prb-in-legacy
branch
from
8273591 to
c5799c4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3645
Changes proposed in this Pull Request:
In the constructor of
includes/payment-methods/class-wc-stripe-payment-request.phpwe are bailing early if ECE feature flag is enabled (which is now enabled by default for everyone). But ECE is available for new checkout experience only. Due to this early bailing, neither ECE nor PRB are being registered when the legacy checkout experience is enabled.Now we are bailing early from PRB only if ECE and the new checkout experience both are enabled.
Testing instructions
New checkout experience.
Legacy checkout experience.