Upgrade React Native to version 0.71.15 #6522
Conversation
The changes in the Xcode project were automatically made after installing pods.
The workaround solves the issue related to redefining `clockid_t` in the pod `RCT-Folly`.
# Conflicts: # gutenberg
| @@ -60,7 +60,6 @@ | |||
| "Yoga": [], | |||
| "DoubleConversion": [], | |||
| "glog": [], | |||
| "React-jsc": [], | |||
There was a problem hiding this comment.
In theory, we no longer use JSC as for both platforms we use hermes. This dependency was introduced here when RN version was upgraded to 0.71.11, but seems it wasn't necessary. That said, I wonder if we could remove the podspec (i.e. third-party-podspecs/React-jsc.podspec.json).
There was a problem hiding this comment.
That said, I wonder if we could remove the podspec (i.e. third-party-podspecs/React-jsc.podspec.json).
I think we could remove it since we are not using it, should we do it with these changes or in a separate PR?
There was a problem hiding this comment.
Yeah, I agree. I'd rather remove the file in a separate PR as the change shouldn't be related to the RN upgrade.
There was a problem hiding this comment.
I'd rather remove the file in a separate PR as the change shouldn't be related to the RN upgrade.
Sounds good!
| # The following workaround is needed to avoid the error `typedef redefinition with different types ('uint8_t' (aka 'unsigned char') vs 'enum clockid_t')`. | ||
| # This solution is referenced in https://github.com/facebook/react-native/issues/39568#issuecomment-1762890606. | ||
| # It will be needed until RCT-Folly version is bumped in React Native to version v2022.08.29.00 or above. | ||
| # Referece: https://github.com/facebook/folly/commit/4a2410fae65afb85e1fec6d922005054b05de59f | ||
| __apply_Xcode_12_5_M1_post_install_workaround(installer) |
There was a problem hiding this comment.
More info can be found in the Gutenberg PR: WordPress/gutenberg#57667
There was a problem hiding this comment.
These changes have been introduced in React Native version 0.71.14 as part of an Xcode 15 patch.
There was a problem hiding this comment.
Approved via WordPress/gutenberg#57667 (review)
There's a failing E2E test but it looks like it's related to the Xpath locator, I've tested the Buttons block and it works as expected 🚀
@geriux I addressed this issue in: I'll trigger full test suites again to confirm it no longer happens. |
# Conflicts: # ios-xcframework/Podfile.lock
I saw that Test iOS on Device – Canary Pages and Test Android on Device – Full failed but they succeeded after retrying the job. I'll now proceed to merge the PRs and create an alpha tag. |
Related PRs:
To test:
Nothing in particular, it should be enough by smoke testing the editor.
PR submission checklist: