CIM Service Tickets page #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DutchBen
reviewed
Nov 1, 2023
packages/orchestrator-ui-components/src/components/WfoProcessesList/WfoProcessList.tsx
Outdated
Show resolved
Hide resolved
DutchBen
reviewed
Nov 1, 2023
packages/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/styles.ts
Outdated
Show resolved
Hide resolved
DutchBen
reviewed
Nov 1, 2023
packages/orchestrator-ui-components/src/components/WfoTable/utils/columns.ts
Outdated
Show resolved
Hide resolved
DutchBen
reviewed
Nov 1, 2023
packages/orchestrator-ui-components/src/hooks/DataFetchHooks.ts
Outdated
Show resolved
Hide resolved
DutchBen
reviewed
Nov 1, 2023
packages/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/WfoBasicTable.tsx
Outdated
Show resolved
Hide resolved
DutchBen
reviewed
Nov 1, 2023
packages/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/styles.ts
Outdated
Show resolved
Hide resolved
|
A more general comment. I'm not sure if we discussed this before and overlooked it but I think that everything that is in the surf package could be in the surf-app directly. There are no plans to publish that so why keep it separate. Let's discuss again. |
|
@DutchBen @ricardovdheijden @acidjunk Can someone of you look into the wfo-ui-surf folder and check if its properly structured like that ? Would you like me to change something in it before I completely delete the surf package. |
DutchBen
approved these changes
Nov 2, 2023
DutchBen
reviewed
Nov 6, 2023
apps/wfo-ui-surf/components/WfoServiceTicketsList/mapServiceTicketStateToColor.ts
Outdated
Show resolved
Hide resolved
DutchBen
reviewed
Nov 6, 2023
DutchBen
reviewed
Nov 6, 2023
DutchBen
reviewed
Nov 6, 2023
...ges/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/WfoStatusColorField.tsx
Outdated
Show resolved
Hide resolved
DutchBen
approved these changes
Nov 6, 2023
Georgi2704
force-pushed
the
cim_service_tickets_new_naming
branch
from
66b9ec5 to
76abeb7
Compare
apps/wfo-ui-surf/components/WfoServiceTicketsList/WfoServiceTicketsList.tsx
Outdated
Show resolved
Hide resolved
apps/wfo-ui-surf/components/WfoServiceTicketsList/WfoServiceTicketsList.tsx
Outdated
Show resolved
Hide resolved
apps/wfo-ui-surf/components/WfoServiceTicketsList/WfoServiceTicketsList.tsx
Outdated
Show resolved
Hide resolved
apps/wfo-ui-surf/components/WfoServiceTicketsList/WfoServiceTicketsList.tsx
Outdated
Show resolved
Hide resolved
...ges/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/WfoStatusColorField.tsx
Outdated
Show resolved
Hide resolved
DutchBen
approved these changes
Nov 6, 2023
packages/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/WfoBasicTable.tsx
Outdated
Show resolved
Hide resolved
...ges/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/WfoStatusColorField.tsx
Outdated
Show resolved
Hide resolved
packages/orchestrator-ui-components/src/components/WfoTable/WfoBasicTable/styles.ts
Outdated
Show resolved
Hide resolved
packages/orchestrator-ui-components/src/hooks/useOrchestratorTheme.ts
Outdated
Show resolved
Hide resolved
…moved to the wfo-surf-ui app
Georgi2704
force-pushed
the
cim_service_tickets_new_naming
branch
from
56a8add to
b4ab278
Compare
ricardovdheijden
approved these changes
Nov 8, 2023
DutchBen
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Service ticket page with the new naming convention applied and pages moved to the wfo-surf-ui app * Changed tab structure for service tickets page wip * Added filtering for Active and Completed service tickets. * linted * 411: Last commit before files are moved to wfo-ui-surf app * 411: Moved surf specific pages and components to the wfo-ui-surf * 411: Removed surf package * Service ticket page in wfo-ui-surf app, + new badge and color components * 411: Some fixes and refactoring * 411: Resolved comments * 411: resolved some comments * 411 Moves the status color column into the basic table * 411 Resolved all comments --------- Co-authored-by: Ricardo van der Heijden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service ticket page with the naming applied and pages moved to the wfo-surf-ui app.