Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TestContainers instead of OpenTable Embedded PostgreSQL. #211

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

SanjayVas
Copy link
Member

Since Embedded PostgreSQL switched to using a container in v1.0, there's not much benefit to using that custom solution over TestContainers.

From the Embedded PostgreSQL FAQ:

  • Why not just use Testcontainers directly?

    You can, and it should work well for you. The builders, the api compatibility, the wrapping around Flyway - that's the added value. But certainly there's no real reason you can't use TestContainers directly - they have their own Junit4 and Junit5 Rules/Extensions.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Contributor

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @YuhongWang-Amazon)

Copy link
Contributor

@YuhongWang-Amazon YuhongWang-Amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas changed the base branch from sanjayvas-cli-testing to main August 11, 2023 21:03
@SanjayVas
Copy link
Member Author

Going to hold off on merging this until we have a corresponding PR ready in the main repo.

@SanjayVas SanjayVas merged commit 07b3f0f into main Aug 16, 2023
2 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-postgres-testing branch August 16, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants