Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Instrument thread pools #278

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-thread-pool-instrumentation branch from a449dda to e3ebba0 Compare September 24, 2024 20:25
Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/common/Instrumentation.kt line 57 at r1 (raw file):

  /** Registers the specified thread pool for instrumentation. */
  fun registerThreadPool(poolName: String, threadPool: ThreadPoolExecutor) {

this should get a test

@SanjayVas SanjayVas marked this pull request as draft September 25, 2024 16:55
Base automatically changed from sanjayvas-rules-oci to main September 25, 2024 17:21
@SanjayVas SanjayVas force-pushed the sanjayvas-thread-pool-instrumentation branch from e3ebba0 to 532b8f1 Compare September 25, 2024 17:23
Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-thread-pool-instrumentation branch 3 times, most recently from e44b867 to 7319d0e Compare September 26, 2024 01:00
@SanjayVas SanjayVas marked this pull request as ready for review September 26, 2024 01:00
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 11 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


src/main/kotlin/org/wfanet/measurement/common/Instrumentation.kt line 57 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

this should get a test

Done.


src/main/kotlin/org/wfanet/measurement/common/Instrumentation.kt line 35 at r3 (raw file):

  /** Singleton [OpenTelemetry] instance which may be initialized by the Java agent. */
  val openTelemetry: OpenTelemetry by lazy {
    // Using lazy delegate to avoid accessing global instance before it's initialized.

Refactored this a bit to avoid having GlobalOpenTelemetry.get() called during static initialization. PTAL

@SanjayVas SanjayVas force-pushed the sanjayvas-thread-pool-instrumentation branch 9 times, most recently from a2bdcf3 to d8e7565 Compare September 27, 2024 00:21
Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 10 files at r3, 1 of 3 files at r4, 2 of 6 files at r5, all commit messages.
Reviewable status: 9 of 13 files reviewed, 2 unresolved discussions (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/common/InvalidatableLazy.kt line 20 at r4 (raw file):

/** [Lazy] which can be invalidated. */
class InvalidatableLazy<T> internal constructor(private val initializer: () -> T) : Lazy<T> {

needs a test

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 13 files reviewed, 2 unresolved discussions (waiting on @stevenwarejones)


src/main/kotlin/org/wfanet/measurement/common/InvalidatableLazy.kt line 20 at r4 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

needs a test

Done.

Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 6 files at r5, 1 of 2 files at r6.
Reviewable status: 11 of 14 files reviewed, all discussions resolved

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 6 files at r5, 1 of 2 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit 4778eb1 into main Oct 2, 2024
3 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-thread-pool-instrumentation branch October 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants