-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Instrument thread pools #278
Conversation
a449dda
to
e3ebba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/common/Instrumentation.kt
line 57 at r1 (raw file):
/** Registers the specified thread pool for instrumentation. */ fun registerThreadPool(poolName: String, threadPool: ThreadPoolExecutor) {
this should get a test
e3ebba0
to
532b8f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
e44b867
to
7319d0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 11 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
src/main/kotlin/org/wfanet/measurement/common/Instrumentation.kt
line 57 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
this should get a test
Done.
src/main/kotlin/org/wfanet/measurement/common/Instrumentation.kt
line 35 at r3 (raw file):
/** Singleton [OpenTelemetry] instance which may be initialized by the Java agent. */ val openTelemetry: OpenTelemetry by lazy { // Using lazy delegate to avoid accessing global instance before it's initialized.
Refactored this a bit to avoid having GlobalOpenTelemetry.get() called during static initialization. PTAL
a2bdcf3
to
d8e7565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 10 files at r3, 1 of 3 files at r4, 2 of 6 files at r5, all commit messages.
Reviewable status: 9 of 13 files reviewed, 2 unresolved discussions (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/common/InvalidatableLazy.kt
line 20 at r4 (raw file):
/** [Lazy] which can be invalidated. */ class InvalidatableLazy<T> internal constructor(private val initializer: () -> T) : Lazy<T> {
needs a test
d8e7565
to
825eb55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 13 files reviewed, 2 unresolved discussions (waiting on @stevenwarejones)
src/main/kotlin/org/wfanet/measurement/common/InvalidatableLazy.kt
line 20 at r4 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
needs a test
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r5, 1 of 2 files at r6.
Reviewable status: 11 of 14 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r5, 1 of 2 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
No description provided.