Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[upstream_utils] Upgrade to fmt 11.1.3 #7629

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[upstream_utils] Upgrade to fmt 11.1.3 #7629

merged 1 commit into from
Jan 30, 2025

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul requested review from PeterJohnson and a team as code owners January 3, 2025 20:11
@github-actions github-actions bot added the component: wpiutil WPI utility library label Jan 3, 2025
@PeterJohnson PeterJohnson added the state: blocked Something is blocking action. label Jan 4, 2025
@PeterJohnson
Copy link
Member

Blocked until after the 2025 season because it's an ABI change that could break vendors that use fmtlib.

@ThadHouse
Copy link
Member

Part of me would be inclined to just do this in 2027, and try to avoid ABI breaks unless we need to even for 2026 roboRIO.

@calcmogul calcmogul force-pushed the upstream-utils-upgrade-fmt branch from c885804 to 7464515 Compare January 13, 2025 22:01
@calcmogul calcmogul changed the title [upstream_utils] Upgrade to fmt 11.1.1 [upstream_utils] Upgrade to fmt 11.1.2 Jan 13, 2025
@calcmogul calcmogul force-pushed the upstream-utils-upgrade-fmt branch from 7464515 to 9a11e19 Compare January 28, 2025 22:55
@calcmogul calcmogul requested review from a team as code owners January 28, 2025 22:55
@calcmogul calcmogul changed the base branch from main to 2027 January 28, 2025 22:55
@calcmogul calcmogul changed the title [upstream_utils] Upgrade to fmt 11.1.2 [upstream_utils] Upgrade to fmt 11.1.3 Jan 28, 2025
@calcmogul calcmogul removed the state: blocked Something is blocking action. label Jan 28, 2025
@calcmogul calcmogul force-pushed the upstream-utils-upgrade-fmt branch from 9a11e19 to 3bfec6e Compare January 28, 2025 23:54
@github-actions github-actions bot added the 2027 2027 target label Jan 28, 2025
@PeterJohnson PeterJohnson merged commit 7533b32 into wpilibsuite:2027 Jan 30, 2025
41 checks passed
@calcmogul calcmogul deleted the upstream-utils-upgrade-fmt branch January 30, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
2027 2027 target component: wpiutil WPI utility library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calcmogul @PeterJohnson @ThadHouse