Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default SMS template inconsistent placeholder #273

Conversation

RushanNanayakkara
Copy link
Contributor

@RushanNanayakkara RushanNanayakkara commented Nov 5, 2024

Proposed changes in this pull request

  • Currently the SMSOTP type system SMS template contains a placeholder {{otpCode}}. This is inconsistent with all other OTP templates.
  • This PR changes the placeholder value of this template to the commonly used {{confirmation-code}}.
  • The necessary code changes for resolving the template is made in the related PRs.

Related Issue

Related PRs

When to merge

After :

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11675583136

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.00%. Comparing base (5b77656) to head (a9ddaac).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage     17.00%   17.00%           
  Complexity      179      179           
=========================================
  Files            53       53           
  Lines          3046     3046           
  Branches        335      335           
=========================================
  Hits            518      518           
  Misses         2487     2487           
  Partials         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11675583136
Status: failure

@RushanNanayakkara RushanNanayakkara merged commit 0559493 into wso2-extensions:master Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants