Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification_templates.sms_templates.apply config. #6104

Conversation

RushanNanayakkara
Copy link
Contributor

@RushanNanayakkara RushanNanayakkara commented Nov 5, 2024

Proposed changes in this pull request

This PR adds a config to control whether to apply sms templates or not. This config is only introduced as a fall back option disable the fix being introduced for the main issue attacked.
This will be removed once the fix is confirmed.

Related Issue

Related PRs

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11675564591

Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.73%. Comparing base (f57b194) to head (4fe08b7).
Report is 26 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6104      +/-   ##
============================================
+ Coverage     40.72%   40.73%   +0.01%     
+ Complexity    14453    14445       -8     
============================================
  Files          1763     1763              
  Lines        117615   117615              
  Branches      19084    19084              
============================================
+ Hits          47896    47912      +16     
+ Misses        62434    62418      -16     
  Partials       7285     7285              
Flag Coverage Δ
unit 24.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11675564591
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11675564591

@RushanNanayakkara RushanNanayakkara merged commit 3e758f9 into wso2:master Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants