Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store content based on the unicode support flag #284

Merged

Conversation

darshanasbg
Copy link
Contributor

Proposed changes in this pull request

$subject. This handles the core logic for the config introduced in:

This temporal behavior enables onboarding the change,

Related to,

When should this PR be merged

After merging wso2/carbon-identity-framework#6142

Follow up actions

N/A

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 3.03030% with 64 lines in your changes missing coverage. Please review.

Project coverage is 32.97%. Comparing base (05ec7dc) to head (cc954ab).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 3.03% 32 Missing ⚠️
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 3.03% 32 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
- Coverage     33.29%   32.97%   -0.32%     
  Complexity      507      507              
============================================
  Files            72       72              
  Lines          4641     4691      +50     
  Branches        560      574      +14     
============================================
+ Hits           1545     1547       +2     
- Misses         2942     2990      +48     
  Partials        154      154              
Flag Coverage Δ
unit 16.69% <3.03%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11937934882

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11937934882
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11937934882

@darshanasbg darshanasbg force-pushed the unicode-support-config branch 2 times, most recently from a1e2e4b to 10e249a Compare November 21, 2024 11:19
@darshanasbg darshanasbg force-pushed the unicode-support-config branch from 10e249a to cc954ab Compare November 21, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants