Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store notification content as binary to support unicode #286

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Nov 21, 2024

Proposed changes in this pull request

$subject. Related to,

When should this PR be merged

After merging,

Follow up actions

When updating product-is versions, both the framework change and this should be update together.

PS:

When updating product-is versions, both the framework change and this should be update together.

Done with:

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 33.29%. Comparing base (e6d5bd5) to head (05ec7dc).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../org/wso2/carbon/email/mgt/util/I18nEmailUtil.java 0.00% 16 Missing ⚠️
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 0.00% 14 Missing ⚠️
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
- Coverage     33.43%   33.29%   -0.15%     
  Complexity      507      507              
============================================
  Files            72       72              
  Lines          4621     4641      +20     
  Branches        559      560       +1     
============================================
  Hits           1545     1545              
- Misses         2922     2942      +20     
  Partials        154      154              
Flag Coverage Δ
unit 16.90% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

notificationTemplateResult.setBody(templateContent[1]);
notificationTemplateResult.setFooter(templateContent[2]);
} else {
throw new SQLException("Invalid content data.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to throw a SQL Exception here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most simple answer is "Yes".. 😃
Let me know if you have any specific concerns..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add more context, this util is used in the DAO impls.. Specifically this is used as a instruction of the RowMapper.mapRow() functional param of the jdbc templates. The RowMapper.mapRow() only allowed to throw exceptions in the type of SQLException.

@darshanasbg darshanasbg merged commit 7088155 into wso2-extensions:master Nov 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants