Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to on-demand migrate notification template content to support unicode #290

Merged

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Dec 3, 2024

Proposed changes in this pull request

$subject by

  • Maintaining notification template content in unicode supported CONTENT column during the add/updates
  • When retrieving, lookup on the unicode supported CONTENT column first and fallback to SUBJECT, BODY, FOOTER columns as the fallback option.

In order to enable this capability, following config should be set in the deployement.toml.

[notification_templates]
enable_unicode_support = "hybrid"

As a backup option, content also kept added/updated to the SUBJECT, BODY, FOOTER columns.. So in a case where it needed to switch from hybrid mode to the false mode, it can be done without loosing any data, apart from unicode support.

This temporal behavior makes it easier to switch to using following changes in graceful manner when the previous schema is already in use.

Related to,

When should this PR be merged

Immediate

Follow up actions

N/A

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12142632257

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12142632257
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12142632257

@darshanasbg darshanasbg merged commit 0474b45 into wso2-extensions:master Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants