Update SAML connection ProviderName config name #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
PR builder started |
|
PR builder completed |
| @@ -57,7 +57,7 @@ public class SSOConstants { | |||
| public static final String SAML_SLO_URL = "/identity/saml/slo"; | |||
| public static final Pattern SAML_SLO_ENDPOINT_URL_PATTERN = Pattern.compile("(.*)/identity/saml/slo/?"); | |||
|
|
|||
| public static final String AUTHN_REQUEST_PROVIDER_NAME = "AuthnReqProviderName"; | |||
There was a problem hiding this comment.
Do we need to remove this? Since it's a public constant, unless we are certain that there are no other use cases, better to keep it.
There was a problem hiding this comment.
This constant was added with my recent PR [1], and is therefore only used here.
[1] #182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the meta information the ProviderName config to be used in the REST API and updates the ProviderName config name.
Related Issues
Related PR