Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAML connection ProviderName config name #7302

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AmshikaH
Copy link
Contributor

@AmshikaH AmshikaH commented Jan 13, 2025

Purpose

Update SAML connection ProviderName config name to "samlAuthnRequestProviderName".

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (6380a4e) to head (ac4589a).
Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7302   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      222      222           
=======================================
  Hits          324      324           
- Misses        555      575   +20     
+ Partials       20        0   -20     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

pavinduLakshan
pavinduLakshan previously approved these changes Jan 13, 2025
@pavinduLakshan pavinduLakshan dismissed their stale review January 13, 2025 15:51

incorrect changeset

@pavinduLakshan
Copy link
Contributor

Changeset is accurate IMO, as in this case, we are renaming a configuration. Therefore connections feature (and also i18n module) should release this update as a major version I think. thoughts @brionmario ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants