Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAML connection ProviderName config name #7302

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update SAML connection ProviderName config name #7302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cefc69b
Update SAML connection ProviderName config name
AmshikaH Jan 13, 2025
ac4589a
Fix eslint issues
AmshikaH Jan 13, 2025
8a9fbe3
Change order of keys
AmshikaH Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/small-radios-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@wso2is/admin.connections.v1": major
"@wso2is/i18n": major
---

Update SAML connection ProviderName config name
26 changes: 14 additions & 12 deletions ...res/admin.connections.v1/components/edit/forms/authenticators/saml-authenticator-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export interface SamlPropertiesInterface {
IncludeCert?: boolean;
IncludeNameIDPolicy?:boolean;
AuthnContextClassRef?: string;
AuthnReqProviderName?: string;
samlAuthnRequestProviderName?: string;
}

const FORM_ID: string = "saml-authenticator-form";
Expand Down Expand Up @@ -250,7 +250,6 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent<SamlSettingsFormPr
AuthRedirectUrl: findPropVal<string>({ defaultValue: authorizedRedirectURL, key: "AuthRedirectUrl" }),
AuthnContextClassRef: findPropVal<string>({ defaultValue: "", key: "AuthnContextClassRef" }),
AuthnContextComparisonLevel: findPropVal<string>({ defaultValue: "", key: "AuthnContextComparisonLevel" }),
AuthnReqProviderName: findPropVal<string>({ defaultValue: "", key: "AuthnReqProviderName" }),
CustomAuthnContextClassRef: findPropVal<string>({ defaultValue: "", key: "CustomAuthnContextClassRef" }),
DigestAlgorithm: findPropVal<string>({ defaultValue: "SHA256", key: "DigestAlgorithm" }),
ForceAuthentication: findPropVal<string>({ defaultValue: "string", key: "ForceAuthentication" }),
Expand Down Expand Up @@ -300,8 +299,11 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent<SamlSettingsFormPr
/**
* https://github.com/wso2/product-is/issues/17004
*/
isAssertionSigned: findPropVal<boolean>({ defaultValue: false, key: "isAssertionSigned" })

isAssertionSigned: findPropVal<boolean>({ defaultValue: false, key: "isAssertionSigned" }),
samlAuthnRequestProviderName: findPropVal<string>({
defaultValue: "",
key: "samlAuthnRequestProviderName"
})
} as SamlPropertiesInterface;

}, []);
Expand Down Expand Up @@ -964,20 +966,20 @@ export const SamlAuthenticatorSettingsForm: FunctionComponent<SamlSettingsFormPr
</SectionRow>
<SectionRow>
<Field.Input
name="AuthnReqProviderName"
value={ formValues?.AuthnReqProviderName }
name="samlAuthnRequestProviderName"
value={ formValues?.samlAuthnRequestProviderName }
inputType="default"
placeholder={ t(`${ I18N_TARGET_KEY }.authnReqProviderName.placeholder`) }
ariaLabel={ t(`${ I18N_TARGET_KEY }.authnReqProviderName.ariaLabel`) }
data-testid={ `${ testId }-authnReqProviderName-field` }
placeholder={ t(`${ I18N_TARGET_KEY }.samlAuthnRequestProviderName.placeholder`) }
ariaLabel={ t(`${ I18N_TARGET_KEY }.samlAuthnRequestProviderName.ariaLabel`) }
data-testid={ `${ testId }-samlAuthnRequestProviderName-field` }
label={ (
<FormInputLabel htmlFor="AuthnReqProviderName">
{ t(`${ I18N_TARGET_KEY }.authnReqProviderName.label`) }
<FormInputLabel htmlFor="samlAuthnRequestProviderName">
{ t(`${ I18N_TARGET_KEY }.samlAuthnRequestProviderName.label`) }
</FormInputLabel>
) }
maxLength={ IDENTITY_PROVIDER_AUTHENTICATION_REQUEST_PROVIDER_NAME_LENGTH.max }
minLength={ IDENTITY_PROVIDER_AUTHENTICATION_REQUEST_PROVIDER_NAME_LENGTH.min }
hint={ t(`${ I18N_TARGET_KEY }.authnReqProviderName.hint`) }
hint={ t(`${ I18N_TARGET_KEY }.samlAuthnRequestProviderName.hint`) }
readOnly={ readOnly }
/>
</SectionRow>
Expand Down
2 changes: 1 addition & 1 deletion modules/i18n/src/models/namespaces/authentication-provider-ns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ export interface AuthenticationProviderNS {
placeholder: string;
ariaLabel: string;
};
authnReqProviderName: {
samlAuthnRequestProviderName: {
hint: string;
label: string;
placeholder: string;
Expand Down
2 changes: 1 addition & 1 deletion modules/i18n/src/translations/en-US/portals/authentication-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ export const authenticationProvider:AuthenticationProviderNS = {
hint: "Specify if SAMLAssertion element is encrypted",
label: "Enable assertion encryption"
},
authnReqProviderName: {
samlAuthnRequestProviderName: {
hint: "The human-readable name of the requester.",
label: "Authentication Request Provider Name",
placeholder: "Enter authentication request provider name",
Expand Down
Loading