fix(subscription): never try to send on blocked channel when subscription was completed #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarpTech
changed the title
5 tasks
jensneuse
approved these changes
Feb 28, 2025
StarpTech
added a commit
that referenced
this pull request
Mar 3, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.162](v2.0.0-rc.161...v2.0.0-rc.162) (2025-03-03) ### Bug Fixes * **subscription:** never try to send on blocked channel when subscription was completed ([#1100](#1100)) ([1a1bb20](1a1bb20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the approach to synchronizing the shutdown of a subscription. Instead of using a separate channel, it now closes the
workChanand terminates the goroutine only after all events have been produced. The final close event will terminate the subscription worker goroutine. The biggest improvement of this change is that closing the channel is done on the same goroutine where subscription are managed. This should eliminate race or deadlock conditions.