transforms: (stencil-tensorize-z-dimension) use DenseIntOrFPElementsAttr constructor #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttr constructor make indextype dense further wip wip wip: make indextype dense further wip wip typo normalize integers s fix print_csl fixes fix pyright issues s resolve reviewer comments update to other pr revert stencil pass change
superlopuh
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3718 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 468 468
Lines 58546 58548 +2
Branches 5652 5652
=======================================
+ Hits 53463 53465 +2
Misses 3631 3631
Partials 1452 1452 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
such that the representation of the attribute can change without affecting this transformation.
To allow for this, the type check
is_tensorneeds to be a bit more restrictive, to only allowTensorType[IndexType|IntegerType|AnyFloat]