Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms: (stencil-tensorize-z-dimension) use DenseIntOrFPElementsAttr constructor #3718

Merged
merged 1 commit into from
Jan 7, 2025
Merged

transforms: (stencil-tensorize-z-dimension) use DenseIntOrFPElementsAttr constructor #3718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions xdsl/transforms/experimental/stencil_tensorize_z_dimension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
ArrayAttr,
ContainerType,
DenseIntOrFPElementsAttr,
FloatAttr,
IndexType,
IntAttr,
IntegerType,
ModuleOp,
ShapedType,
TensorType,
Expand Down Expand Up @@ -193,7 +196,7 @@ def match_and_rewrite(
@staticmethod
def _rewrite_scalar_operand(
scalar_op: SSAValue,
dest_typ: TensorType[Attribute],
dest_typ: TensorType[IndexType | IntegerType | AnyFloat],
op: FloatingPointLikeBinaryOperation,
rewriter: PatternRewriter,
) -> SSAValue:
Expand All @@ -203,8 +206,10 @@ def _rewrite_scalar_operand(
If it is not a constant, create an empty tensor and `linalg.fill` it with the scalar value.
"""
if isinstance(scalar_op, OpResult) and isinstance(scalar_op.op, ConstantOp):
assert isinstance(float_attr := scalar_op.op.value, FloatAttr)
scalar_value = float_attr.value.data
tens_const = ConstantOp(
DenseIntOrFPElementsAttr([dest_typ, ArrayAttr([scalar_op.op.value])])
DenseIntOrFPElementsAttr.from_list(dest_typ, [scalar_value])
)
rewriter.insert_op(tens_const, InsertPoint.before(scalar_op.op))
return tens_const.result
Expand Down Expand Up @@ -265,7 +270,9 @@ def is_tensorized(
return len(typ.get_shape()) == 2 and isinstance(typ.get_element_type(), TensorType)


def is_tensor(typ: Attribute) -> TypeGuard[TensorType[Attribute]]:
def is_tensor(
typ: Attribute,
) -> TypeGuard[TensorType[IndexType | IntegerType | AnyFloat]]:
return isinstance(typ, TensorType)


Expand Down
Loading