Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude / tree-shake Blueprint icon package dependency #1977

Merged
merged 9 commits into from
Jul 17, 2020

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented Jun 28, 2020

This PR implements the solution discussed in this issue:
#1963

This change requires the code change made to hoist-dev-utils in this branch:
https://github.com/xh/hoist-dev-utils/tree/noBluePrintIcons
for which there is also a PR: xh/hoist-dev-utils#25

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required. -- A CHANGELOG entry has been added to Hoist-Dev-Utils.
    Once that is released with a new version number, and this project is updated to use that new version, maybe a
    changelog entry should be added here.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so. -- This should not be breaking change.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@cnrudd cnrudd changed the title No blue print icons Exclude / tree-shake Blueprint icon package dependency Jun 28, 2020
@cnrudd
Copy link
Member Author

cnrudd commented Jun 28, 2020

Here is a screenshot of the icon search I did to determine which icons to put into static/blueprintJsIconSvgPaths.js
Most of the results are Icons used in documentation. I have pointed out the usages that I thought were significant and justified including the icon in the new file.

I did not include the chevron-up/down icons because our use of blueprintJS numericInput disables those increment buttons.

Screen Shot 2020-06-28 at 2 15 09 PM

@amcclain amcclain merged commit 55d73bc into develop Jul 17, 2020
@amcclain amcclain deleted the noBluePrintIcons branch July 17, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants