Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude / tree-shake Blueprint icon package dependency #1977

Merged
merged 9 commits into from
Jul 17, 2020
Merged

Exclude / tree-shake Blueprint icon package dependency #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1afa2c3
Replace all BluePrint icon SVG paths with nothing. emptyIconSvgPaths…
cnrudd Jun 26, 2020
a0913e4
We use at least 3 blueprint icons in our framework.
cnrudd Jun 28, 2020
48229e6
Merge branch 'develop' into noBluePrintIcons
cnrudd Jun 28, 2020
7d1dff8
Refine comments
cnrudd Jun 28, 2020
5f2ba4f
Rename file
cnrudd Jun 28, 2020
8cc5e06
Rename file
cnrudd Jun 28, 2020
389064c
Rename file
cnrudd Jun 28, 2020
fe33399
Merge branch 'develop' into noBluePrintIcons
amcclain Jul 17, 2020
3c07a5e
Comment and changelog entry re. blueprint icons
amcclain Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## v36.0.0-SNAPSHOT - unreleased

### ⚙️ Technical

* Supports smaller bundle sizes via a greatly reduced set of BlueprintJS icons. (Requires apps to be
built with `@xh/hoist-dev-utils` v5.2 or greater to take advantage of this optimization.)

### 📚 Libraries

* @fortawesome/fontawesome-pro `5.13 -> 5.14`
Expand Down
23 changes: 23 additions & 0 deletions static/requiredBlueprintIcons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/**
* This file replaces the MUCH larger versions included within the @blueprintjs/icons dependency,
* which itself is required by Blueprint core. This file is swapped in at build-time by the
* `@xh/hoist-dev-utils` webpack config to only bundle the icons required by BP-based Hoist React
* components, nicely reducing overall app bundle size.
*
* See https://github.com/xh/hoist-react/issues/1963 for further details, see the dev-utils
* `configureWebpack()` method for the implementation referencing this file.
*/
export const IconSvgPaths16 = {
// used on context menu menuItem when a menu has submenus
'caret-right': ['M11 8c0-.15-.07-.28-.17-.37l-4-3.5A.495.495 0 006 4.5v7a.495.495 0 00.83.37l4-3.5c.1-.09.17-.22.17-.37z'],
// used on toast close buttons
'cross': ['M9.41 8l3.29-3.29c.19-.18.3-.43.3-.71a1.003 1.003 0 00-1.71-.71L8 6.59l-3.29-3.3a1.003 1.003 0 00-1.42 1.42L6.59 8 3.3 11.29c-.19.18-.3.43-.3.71a1.003 1.003 0 001.71.71L8 9.41l3.29 3.29c.18.19.43.3.71.3a1.003 1.003 0 00.71-1.71L9.41 8z'],
// used on dialog close buttons
'small-cross': ['M9.41 8l2.29-2.29c.19-.18.3-.43.3-.71a1.003 1.003 0 00-1.71-.71L8 6.59l-2.29-2.3a1.003 1.003 0 00-1.42 1.42L6.59 8 4.3 10.29c-.19.18-.3.43-.3.71a1.003 1.003 0 001.71.71L8 9.41l2.29 2.29c.18.19.43.3.71.3a1.003 1.003 0 00.71-1.71L9.41 8z']

};
export const IconSvgPaths20 = {
'caret-right': ['M14 10c0-.31-.15-.57-.37-.76l.01-.01-6-5-.01.01C7.46 4.1 7.24 4 7 4c-.55 0-1 .45-1 1v10c0 .55.45 1 1 1 .24 0 .46-.1.63-.24l.01.01 6-5-.01-.01c.22-.19.37-.45.37-.76z'],
'cross': ['M11.41 10l4.29-4.29c.19-.18.3-.43.3-.71a1.003 1.003 0 00-1.71-.71L10 8.59l-4.29-4.3a1.003 1.003 0 00-1.42 1.42L8.59 10 4.3 14.29c-.19.18-.3.43-.3.71a1.003 1.003 0 001.71.71l4.29-4.3 4.29 4.29c.18.19.43.3.71.3a1.003 1.003 0 00.71-1.71L11.41 10z'],
'small-cross': ['M11.41 10l3.29-3.29c.19-.18.3-.43.3-.71a1.003 1.003 0 00-1.71-.71L10 8.59l-3.29-3.3a1.003 1.003 0 00-1.42 1.42L8.59 10 5.3 13.29c-.19.18-.3.43-.3.71a1.003 1.003 0 001.71.71l3.29-3.3 3.29 3.29c.18.19.43.3.71.3a1.003 1.003 0 00.71-1.71L11.41 10z']
};