-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to work with the latest version of sentence transformers #112
Updated to work with the latest version of sentence transformers #112
Conversation
cc @hongjin-su I haven't tested this myself, but this seems quite important to prevent the critical failures currently encountered when installing, e.g. #106. For others, I would recommend the following:
After which your code should work with the most recent Sentence Transformers version again.
|
Hello @SilasMarvin First, thanks for this fork and thanks to @tomaarsen for pointing it out. I'd been trying to get instructor models to work with Regardless of the reason, I've asked |
Hey! @BBC-Esq I have not gotten any response from the maintainers. This honestly is not the best fix. The new version of sentence-transformers has some nice utilities for loading in files and managing different versions which I did not implement, but this should work as a hot fix for people having issues. I'll take a look at the discussion! |
Please do take a look, and thanks again. I think you'll understand my challenge. |
This is great, I hope it could get merged. |
Thanks for all your help! I will merge it after conflicts are resolved. |
Awesome! Conflicts resolved |
@hongjin-su will there be a new PyPi release soon? Also for anyone who needs this fix in the meantime, you can pin this:
|
Please a new pypi release. These maintainers are slow to act. |
@SilasMarvin I just realized one thing: the https://github.com/UKPLab/sentence-transformers/blob/66e0ee30843dd411c64f37f65447bb38c7bf857a/sentence_transformers/util.py#L544 from which you took the code includes the https://github.com/UKPLab/sentence-transformers/blob/66e0ee30843dd411c64f37f65447bb38c7bf857a/sentence_transformers/util.py#L552-L554 too which lets you use the model locally without the connection to the internet, is there any reason why it's not included or why you haven't used the |
Is this why when I specify a path on my computer it gives an error saying it's not a correct repository ID on huggingface or what not? |
My most recent pull request solves it |
yes, exactly, that's why it complains about the repository ID, because it went straight to the validation without prior check for local drive |
The latest version of sentence transformers changed the arguments to the
_load_sbert_model
and changed the download system. This is a small update to make it compatible.