-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: request validation check #394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 52.44% 53.46% +1.01%
==========================================
Files 98 100 +2
Lines 15100 15531 +431
Branches 15100 15531 +431
==========================================
+ Hits 7919 8303 +384
- Misses 6686 6727 +41
- Partials 495 501 +6
☔ View full report in Codecov by Sentry. |
bsbds
force-pushed
the
add-check
branch
4 times, most recently
from
July 26, 2023 11:37
950e0e1
to
cc0639a
Compare
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
…e_compacted` Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Merged
iGxnon
reviewed
Aug 4, 2023
rogercloud
reviewed
Aug 4, 2023
…sions Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
rogercloud
approved these changes
Aug 4, 2023
themanforfree
approved these changes
Aug 4, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described in: #398
Based on: #399
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Currently some of the validation checks are done in the RPC server. However, these checks are not applied in the storage request handlers (eg.
handle_range_request
), so that the request from outside client will not be checked.what changes does this pull request make?
This pull request applied the validation check in both RPC server and the storage handlers.
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)