chore: downgrade github artifact to v3 from v4 for publish docker image. #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liangyuanpeng You've modified the workflows. Please don't forget to update the .mergify.yml. |
liangyuanpeng
force-pushed
the
downgrade_artifact
branch
from
d4d7f1b to
90a2598
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #809 +/- ##
==========================================
- Coverage 75.55% 75.47% -0.08%
==========================================
Files 180 186 +6
Lines 26938 27478 +540
Branches 26938 27478 +540
==========================================
+ Hits 20353 20740 +387
- Misses 5366 5467 +101
- Partials 1219 1271 +52 ☔ View full report in Codecov by Sentry. |
|
Please ignore the auto update of the upload-artifact in dependabot.yml. Otherwise, it will be auto update in next time. |
liangyuanpeng
force-pushed
the
downgrade_artifact
branch
2 times, most recently
from
9541724 to
bfd9c4a
Compare
Phoenix500526
approved these changes
May 10, 2024
liangyuanpeng
added
the
github_actions
rogercloud
reviewed
May 18, 2024
artifact v4 do not support upload artifact with the same name, https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact , so this is working for downgrade v4 to v3, until we get rid of using github jobs to build multi-architecture container images. see xline-kv#809 Signed-off-by: Lan Liang <[email protected]>
liangyuanpeng
force-pushed
the
downgrade_artifact
branch
from
bfd9c4a to
769125e
Compare
Sure, PTAL again,Thanks. |
Phoenix500526
approved these changes
May 20, 2024
rogercloud
approved these changes
May 29, 2024
|
Since this PR have two approval, does ready merge it is time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
artifact v4 do not support upload artifact with the same name, https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact , so this PR is working for downgrade v4 to v3, until we get rid of using github jobs to build multi-architecture container images.
so release workflow is also broken,
Xline/.github/workflows/release.yml
Line 144 in dca4449
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)