refactor(client)!: Remove request wrappers - AuthClient::role_revoke_permission #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 75.55% 76.20% +0.64%
==========================================
Files 180 189 +9
Lines 26938 28753 +1815
Branches 26938 28753 +1815
==========================================
+ Hits 20353 21910 +1557
- Misses 5366 5528 +162
- Partials 1219 1315 +96 ☔ View full report in Codecov by Sentry. |
|
@lxl66566 Your PR is in conflict and cannot be merged. |
Signed-off-by: lxl66566 <[email protected]> fix: add test Signed-off-by: lxl66566 <[email protected]> fix(client): fix doc test Signed-off-by: lxl66566 <[email protected]>
lxl66566
force-pushed
the
refactor-client-role-revoke-permission
branch
from
1ca1dd5 to
bcda864
Compare
|
@lxl66566 Convert your pr to draft since CI failed |
bsbds
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #882
close #819
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)