[198] Trait for pub API in EncryptedFs #200
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 11, 2024 00:51
…block for EncryptedFs into a trait implementation block
… method return (as in FsResult<impl ...>) is not authorized anymore. Change is to move to Box<dyn ...>. This change implied small changes in methods implementation as well as in other methods using the impacted methods.
radumarias
previously approved these changes
Sep 13, 2024
…e the issue induced by the previous changes
moved new() method from trait impl block to impl block
|
@HugoBal what's the staus on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Work in progress]
Create a trait EncryptedFilesystem which contains all pub methods from EncryptedFs.