Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve multisig upgrade tutorial #1429

Merged
merged 49 commits into from
Nov 26, 2024
Merged

docs: improve multisig upgrade tutorial #1429

merged 49 commits into from
Nov 26, 2024

Conversation

JuArce
Copy link
Collaborator

@JuArce JuArce commented Nov 15, 2024 •
edited
Loading

Improve multisig upgrade tutorial

Description

This PR improves the deploy, upgrade and multisig approves tutorials

All the docs are in docs/0_internal

@JuArce JuArce self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Changes to gas cost

Generated at commit: e67f2cffe079ea514a9340972858a708edc2b426, compared to commit: fecac6f71e5a46592806d2746c26dbf9d38c2ea2

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask +61 ❌ +0.08%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 5,231,234 (0) createNewTask 56,047 (-12) -0.02% 76,099 (+61) +0.08% 76,259 (+72) +0.09% 77,030 (+60) +0.08% 256 (0)

@JuArce JuArce marked this pull request as ready for review November 21, 2024 16:24
uri-99
uri-99 reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP review

docs/0_internal/1_multisig_creation.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/2_deploy_contracts.md Outdated Show resolved Hide resolved
docs/0_internal/3_a_upgrade_contracts.md Outdated Show resolved Hide resolved
MarcosNicolau
MarcosNicolau approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation seemed really clear to me. Left a small comment on the upgrade guide, it is not necessary thou.

Makefile Show resolved Hide resolved
docs/0_internal/3_b_1_deploy_new_impl.md Outdated Show resolved Hide resolved
@MauroToscano MauroToscano added this pull request to the merge queue Nov 26, 2024
Merged via the queue into staging with commit 86692fc Nov 26, 2024
3 checks passed
@MauroToscano MauroToscano deleted the 1421-docs-improve-multisig-upgrade-tutorial branch November 26, 2024 14:46
@JuArce JuArce mentioned this pull request Nov 26, 2024
Merged
14 tasks
PatStiles pushed a commit that referenced this pull request Nov 27, 2024
@JuArce @uri-99
@MauroToscano @PatStiles
docs: improve multisig upgrade tutorial (#1429)
13bd340 
Co-authored-by: Uriel Mihura <[email protected]>
Co-authored-by: Mauro Toscano <[email protected]>
Co-authored-by: MauroFab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

@uri-99 uri-99 uri-99 approved these changes

@MauroToscano MauroToscano MauroToscano approved these changes

Assignees

@JuArce JuArce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuArce @MauroToscano @uri-99 @MarcosNicolau