Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): fix dev and tests on Windows #386

Merged
merged 16 commits into from
Sep 11, 2023
Merged

fix(dev): fix dev and tests on Windows #386

merged 16 commits into from
Sep 11, 2023

Commits on Sep 6, 2023

  1. fix(dev): fix dev and tests on Windows 

    Fixes issues with paths in various places.

Convert to posix paths in globSync and Windows paths for filepaths when
appropriate.

Unit tests pass and npm run dev works as expected.
Pages are fully functional and appear the same as on MacOS.
    @jwartofsky-yext
    jwartofsky-yext committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b01240d View commit details
    Browse the repository at this point in the history

  2. fix(dev): fix dev and tests on Windows 

    Fixes issues with paths in various places.

Convert to posix paths in globSync and Windows paths for filepaths when
appropriate.

Unit tests pass and npm run dev works as expected.
Pages are fully functional and appear the same as on MacOS.
    @jwartofsky-yext
    jwartofsky-yext committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    49b5784 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fixWindowsTestsAndDev' of https://github.com/yext/pages … 

    …into fixWindowsTestsAndDev
    @jwartofsky-yext
    jwartofsky-yext committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    41c501b View commit details
    Browse the repository at this point in the history

  4. Commit new snapshots for macos-latest

    @github-actions
    github-actions[bot] committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1b752f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Empty commit

    @jwartofsky-yext
    jwartofsky-yext committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    b8e6f9d View commit details
    Browse the repository at this point in the history

  2. Removed convertToOSPath 

    Reran all tests
    @jwartofsky-yext
    jwartofsky-yext committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    b15abf8 View commit details
    Browse the repository at this point in the history

  3. fix tests for Posix systems 

    In several places we compare a hash of the URL, which is different
depending on the system.
    @jwartofsky-yext
    jwartofsky-yext committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    484387d View commit details
    Browse the repository at this point in the history

  4. cleanup paths helper

    @jwartofsky-yext
    jwartofsky-yext committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    142aadd View commit details
    Browse the repository at this point in the history

  5. replcae path.sep with "\\" for convertToPosixPath 

    Without this, the method will fail to convert a Windows URL to Posix
on Mac.
    @jwartofsky-yext
    jwartofsky-yext committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2a07bb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. use path.sep instead of \

    @jwartofsky-yext
    jwartofsky-yext committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d72789f View commit details
    Browse the repository at this point in the history

  2. fix loader path for Node19+ on Windows

    @jwartofsky-yext
    jwartofsky-yext committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    dc90f70 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fixWindowsTestsAndDev

    @jwartofsky-yext
    jwartofsky-yext authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8db0cad View commit details
    Browse the repository at this point in the history

  4. address comments

    @jwartofsky-yext
    jwartofsky-yext committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    eeae30b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. fixed npm run prod. tested generate commands

    @jwartofsky-yext
    jwartofsky-yext committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a156b0a View commit details
    Browse the repository at this point in the history

  2. fix subprocess test

    @jwartofsky-yext
    jwartofsky-yext committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a765ea2 View commit details
    Browse the repository at this point in the history

  3. restore react-dom/client

    @jwartofsky-yext
    jwartofsky-yext committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    58d9f20 View commit details
    Browse the repository at this point in the history