-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt code to string immutability #98
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new Zlib2 module.
Ported updates from the upstream repo of the syslog module up to revision becc8c4 version 2.0.2.
… a conflict with libc++'s invalid_argument symbol.
ygrek
added a commit
that referenced
this pull request
Jun 10, 2024
ygrek
added a commit
that referenced
this pull request
Jun 11, 2024
ygrek
added a commit
that referenced
this pull request
Jun 15, 2024
ygrek
added a commit
that referenced
this pull request
Jun 16, 2024
I picked up some changes from this PR to builds for me with
Thanks a lot! |
Merged
carlonluca
force-pushed
the
immutable-strings
branch
5 times, most recently
from
June 25, 2024 18:02
513eaa2
to
cff78b0
Compare
carlonluca
force-pushed
the
immutable-strings
branch
from
June 26, 2024 17:00
cff78b0
to
cc8d93d
Compare
#99 takes care of this, thanks for the push to get it done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling with recent versions of the ocaml compiler requires to respect the string immutability rule. This patch allows to build mldonkey without the unsafe strings switch, thus opening to new compiler versions and recent distros.
Respecting the string immutability rule required more byte/string conversions, which results in more copies. More refactoring is needed to prevent these copies.
This patch should close #46.