Adapt code to string immutability

config/configure.in

@@ -690,10 +690,6 @@ if test "$OCAMLVERSION" \< "$MINIMUM_OCAML"; then
   exit 1
 fi
 
-if test ! "$OCAMLVERSION" \< "4.03.0"; then
-  OCAMLC="$OCAMLC -unsafe-string"
-fi
-
 if test "$OCAMLOPT" = "no"; then
   TARGET_TYPE=byte
   OCAMLLIB_EXT=cma
@@ -707,11 +703,6 @@ else
     echo "******** Expected ocamlopt version $OCAMLVERSION , but got $OCAMLOPTVERSION *********" 1>&2;
     echo "*******  Check http://ocaml.org/  ********" 1>&2;
     exit 1; }
-
-  if test ! "$OCAMLVERSION" \< "4.03.0"; then
-    OCAMLOPT="$OCAMLOPT -unsafe-string"
-  fi
-
 fi
 
 echo "-------------------------------------------"

src/config/unix/os_stubs_c.c

@@ -127,7 +127,7 @@ int64_t os_getfdsize(OS_FD fd)
 
 *******************************************************************/
 
-int64_t os_getfilesize(char *path)
+int64_t os_getfilesize(const char *path)
 {
   struct stat buf;
 

src/daemon/common/commonComplexOptions.ml

@@ -1156,9 +1156,9 @@ let backup_tar archive files =
               t_devminor = 0;
               t_prefix = "";
               t_gnu = None;} in
-            let s = String.create size in
+            let s = Bytes.create size in
             Pervasives.really_input ic s 0 size;
-            header, s) in
+            header, Bytes.unsafe_to_string s) in
         Tar.output otar header s
       with
       | e ->

src/daemon/common/commonDownloads.ml

@@ -87,7 +87,7 @@ module Make(M: sig
           in
           let final_pos = Unix32.seek64 (file_fd file) d.download_pos
               Unix.SEEK_SET in *)
-        Unix32.write (file_fd file) d.download_pos b.buf b.pos b.len;
+        Unix32.write_bytes (file_fd file) d.download_pos b.buf b.pos b.len;
 (*        end; *)
 (*      lprintf "DIFF %d/%d\n" nread b.len; *)
         d.download_pos <- d.download_pos ++ (Int64.of_int b.len);

src/daemon/common/commonFile.ml

@@ -975,7 +975,7 @@ let recover_bytes file =
     if pos = max then
       iter_file_out file_pos segments
     else
-    if s.[pos] = '\000' then
+    if Bytes.get s pos = '\000' then
       iter_string_out file_pos (pos+1) max segments
     else
     let begin_pos = file_pos -- (Int64.of_int (max - pos)) in
@@ -995,7 +995,7 @@ let recover_bytes file =
     if pos = max then
       iter_file_in file_pos begin_pos segments
     else
-    if s.[pos] = '\000' then
+    if Bytes.get s pos = '\000' then
       let end_pos = file_pos -- (Int64.of_int (max - pos)) in
 (*      lprintf "  0 byte at %Ld\n" end_pos; *)
       iter_string_out file_pos (pos+1) max 

src/daemon/common/commonMultimedia.ml

@@ -41,10 +41,7 @@ let input_int ic =
   let i1 = input_int16 ic in
   i0 lor (i1 lsl 16)
 
-let input_string4 ic =
-  let s = String.create 4 in
-  really_input ic s 0 4;
-  s
+let input_string4 ic = really_input_string ic 4
 
 let print_string4 v s =
   lprintf "%s :" v;
@@ -230,7 +227,7 @@ let rec page_seek ic s pos =
     else begin
       really_input ic s 0 4;
       seek_in ic (pos_in ic - 3);
-      if s = "OggS"
+      if Misc.bytes_equal_string s "OggS"
         then seek_in ic (pos_in ic + 3)
         else page_seek ic s pos
   end
@@ -278,12 +275,10 @@ let rec next_ogg_stream ic ogg_infos str stream_number =
   lprintf "Stream Serial Number: %0.f\n" stream_number;
 *)
   seek_in ic (pos+24);
-  let content_type = String.create 1 in
-  really_input ic content_type 0 1;
+  let content_type = really_input_string ic 1 in
   let content_type = int_of_char content_type.[0] in
   seek_in ic (pos+25);
-  let stream_type = String.create 8 in
-  really_input ic stream_type 0 8;
+  let stream_type = really_input_string ic 8 in
   let stream_type = normalize_stream_type stream_type content_type in
   incr stream_number;
   let pos = pos_in ic in
@@ -299,8 +294,7 @@ let rec next_ogg_stream ic ogg_infos str stream_number =
     | OGG_THEORA_STREAM -> get_ogg_theora_info ic ogg_infos str stream_number
 
 and get_ogg_video_info  ic ogg_infos str sizeof_packet stream_number =
-  let s = String.create sizeof_packet in
-  really_input ic s 0 sizeof_packet;
+  let s = really_input_string ic sizeof_packet in
   let codec = String.lowercase (String.sub s 0 4) in
   let time_unit = read64 (String.sub s 8 8) in
   let video_width =
@@ -326,8 +320,7 @@ and get_ogg_video_info  ic ogg_infos str sizeof_packet stream_number =
   next_ogg_stream ic ogg_infos str stream_number
 
 and get_ogg_audio_info  ic ogg_infos str sizeof_packet stream_number =
-  let s = String.create sizeof_packet in
-  really_input ic s 0 sizeof_packet;
+  let s = really_input_string ic sizeof_packet in
   let codec = get_audio_codec (String.sub s 0 4) in
   let sample_per_unit = read64 (String.sub s 16 8) in
   let channels =
@@ -359,8 +352,7 @@ and get_ogg_audio_info  ic ogg_infos str sizeof_packet stream_number =
 
 and get_ogg_vorbis_info  ic ogg_infos str stream_number =
   seek_in ic (pos_in ic - 2); (* ogm sets 8 octets in the common header as vorbis uses 6 octects for 'vorbis' *)
-  let s = String.create 22 in
-  really_input ic s 0 22;
+  let s = really_input_string ic 22 in
   let version = read32 (String.sub s 0 4) in
   let audio_channels = int_of_char s.[4] in
   let sample_rate = read32 (String.sub s 5 4) in
@@ -389,8 +381,7 @@ and get_ogg_vorbis_info  ic ogg_infos str stream_number =
 
 and get_ogg_theora_info  ic ogg_infos str stream_number =
   seek_in ic (pos_in ic - 2); (* ogm sets 8 octets in the common header as theora uses 6 octects for 'theora' *)
-  let s = String.create 34 in
-  really_input ic s 0 34;
+  let s = really_input_string ic 34 in
   let vmaj = int_of_char s.[0] in
   let vmin = int_of_char s.[1] in
   let vrev = int_of_char s.[2] in
@@ -451,7 +442,7 @@ and get_ogg_index_info ic ogg_infos str stream_number =
 
 let search_info_ogg ic =
     let stream_number = ref 0 in
-    let str = String.create 4 in
+    let str = Bytes.create 4 in
     let ogg_infos = ref [] in
     (* make sure the current reading position is at the file beginning *)
     seek_in ic 0;

src/daemon/common/commonSwarming.ml

@@ -140,7 +140,7 @@ and swarmer = {
     mutable s_strategy : swarming_strategy;
 
     mutable s_verified_bitmap : VerificationBitmap.t;
-    mutable s_priorities_bitmap : string;
+    mutable s_priorities_bitmap : bytes;
     mutable s_priorities_intervals : (int64 * int) list;
                                        (* beginning, priority *)
     mutable s_disk_allocated : Bitv.t;
@@ -579,7 +579,7 @@ let dummy_swarmer = {
     s_networks = [];
     s_strategy = AdvancedStrategy;
     s_verified_bitmap = VB.create 0 VB.State_missing;
-    s_priorities_bitmap = "";
+    s_priorities_bitmap = Bytes.empty;
     s_priorities_intervals = [(zero, 1)];
     s_disk_allocated = Bitv.create 0 false;
     s_blocks = [||];
@@ -639,7 +639,7 @@ let priority_zero = Char.chr 0
 
 let swarmer_recompute_priorities_bitmap s =
   String.fill s.s_priorities_bitmap 0
-    (String.length s.s_priorities_bitmap) priority_zero;
+    (Bytes.length s.s_priorities_bitmap) priority_zero;
   let mark interval_begin interval_end priority =
     if interval_end > interval_begin && s.s_size >= interval_end && interval_begin >= 0L then
       if priority = 0 then
@@ -704,7 +704,7 @@ let create_swarmer file_name file_size =
       s_strategy = AdvancedStrategy;
 
       s_verified_bitmap = VB.create nblocks VB.State_missing;
-      s_priorities_bitmap = String.make nblocks priority_zero;
+      s_priorities_bitmap = Bytes.make nblocks priority_zero;
       s_priorities_intervals = [(zero, 1)]; (* JAVE init all prios to 1, thus all chunks will be downloaded as usual *)
       s_disk_allocated = Bitv.create ndiskblocks false;
       s_blocks = Array.make nblocks EmptyBlock ;
@@ -837,7 +837,7 @@ let split_blocks s chunk_size =
 
   s.s_blocks <- Array.make nblocks EmptyBlock;
   s.s_verified_bitmap <- VB.create nblocks VB.State_missing;
-  s.s_priorities_bitmap <- String.make nblocks priority_zero;
+  s.s_priorities_bitmap <- Bytes.make nblocks priority_zero;
   s.s_block_pos <- Array.make nblocks zero;
   s.s_availability <- Array.make nblocks 0; (* not preserved ? *)
   s.s_nuploading <- Array.make nblocks 0; (* not preserved ? *)
@@ -2041,7 +2041,7 @@ let linear_select_blocks up =
     up.up_npartial <- n-1;
     let t = up.up_t in
     let s = t.t_s in
-    if s.s_priorities_bitmap.[b] = priority_zero then iter_partial up else
+    if (Bytes.get s.s_priorities_bitmap b) = priority_zero then iter_partial up else
     let chunk = t.t_chunk_of_block.(b) in
     match s.s_blocks.(b) with
     | CompleteBlock | VerifiedBlock ->
@@ -2067,7 +2067,7 @@ let linear_select_blocks up =
       up.up_ncomplete <- n-1;
       let t = up.up_t in
       let s = t.t_s in
-      if s.s_priorities_bitmap.[b] = priority_zero then iter_complete up else
+      if (Bytes.get s.s_priorities_bitmap b) = priority_zero then iter_complete up else
       let chunk = t.t_chunk_of_block.(b) in
       match s.s_blocks.(b) with
       | CompleteBlock | VerifiedBlock ->
@@ -2238,7 +2238,7 @@ let select_blocks up =
           {
             choice_num = n;
             choice_block = b;
-            choice_user_priority = Char.code s.s_priorities_bitmap.[b];
+            choice_user_priority = Char.code (Bytes.get s.s_priorities_bitmap b);
             choice_remaining = remaining;
             choice_preallocated = is_fully_preallocated t block_begin block_end;
             choice_unselected_remaining = unselected_remaining;
@@ -2387,7 +2387,7 @@ let select_blocks up =
           Array2.subarray_fold_lefti (fun 
             ((current_chunk_num, current_chunk_blocks_indexes, 
             best_choices, specimen) as acc) n b ->
-            if s.s_priorities_bitmap.[b] = priority_zero ||
+            if (Bytes.get s.s_priorities_bitmap b) = priority_zero ||
               not (should_download_block s b) then acc
             else
               let chunk_num = t.t_chunk_of_block.(b) in
@@ -2733,7 +2733,7 @@ let find_range up range_size =
           let block = up.up_complete_blocks.(i) in
           if not (List.exists (fun b -> b.up_block.block_num = block
                               ) up.up_blocks) then
-            if s.s_priorities_bitmap.[block] <> priority_zero && 
+            if (Bytes.get s.s_priorities_bitmap block) <> priority_zero && 
               should_download_block s block then
               let partial_found = match s.s_blocks.(block) with
                 | EmptyBlock -> true

src/daemon/common/commonUploads.ml

@@ -290,7 +290,7 @@ let shared_tree = new_shared_dir ""
 
 let md4_of_list md4s =
   let len = List.length md4s in
-  let s = String.create (len * 16) in
+  let s = Bytes.create (len * 16) in
   let rec iter list i =
     match list with
       [] -> ()
@@ -300,7 +300,7 @@ let md4_of_list md4s =
         iter tail (i+16)
   in
   iter md4s 0;
-  Md4.string s
+  Md4.string @@ Bytes.unsafe_to_string s
 
 let rec tiger_of_array array pos block =
   if block = 1 then
@@ -312,11 +312,11 @@ let rec tiger_of_array array pos block =
   else
   let d1 = tiger_of_array array pos (block/2) in
   let d2 = tiger_of_array array (pos+block/2) (block/2) in
-  let s = String.create (1 + Tiger.length * 2) in
+  let s = Bytes.create (1 + Tiger.length * 2) in
   s.[0] <- '\001';
   String.blit (TigerTree.direct_to_string d1) 0 s 1 Tiger.length;
   String.blit (TigerTree.direct_to_string d2) 0 s (1+Tiger.length) Tiger.length;
-  let t = Tiger.string s in
+  let t = Tiger.string @@ Bytes.unsafe_to_string s in
   let t = TigerTree.direct_of_string (Tiger.direct_to_string t) in
   t
 
@@ -345,11 +345,11 @@ let rec tiger_pos2 nblocks =
   pos, list
 
 let tiger_node d1 d2 =
-  let s = String.create (1 + Tiger.length * 2) in
+  let s = Bytes.create (1 + Tiger.length * 2) in
   s.[0] <- '\001';
   String.blit (TigerTree.direct_to_string d1) 0 s 1 Tiger.length;
   String.blit (TigerTree.direct_to_string d2) 0 s (1+Tiger.length) Tiger.length;
-  let t = Tiger.string s in
+  let t = Tiger.string @@ Bytes.unsafe_to_string s in
   let t = TigerTree.direct_of_string (Tiger.direct_to_string t) in
   t
 
@@ -386,12 +386,12 @@ let rec fill_tiger_tree s list =
 
 let flatten_tiger_array array =
   let len = Array.length array in
-  let s = String.create ( len * TigerTree.length) in
+  let s = Bytes.create ( len * TigerTree.length) in
   for i = 0 to len - 1 do
     String.blit (TigerTree.direct_to_string array.(i)) 0
       s (i * TigerTree.length) TigerTree.length
   done;
-  s
+  Bytes.unsafe_to_string s
 
 let unflatten_tiger_array s =
   let len = String.length s / TigerTree.length in
@@ -504,9 +504,9 @@ computation ??? *)
             let file_size = Unix32.getsize64 fd in
             let len64 = min 307200L file_size in
             let len = Int64.to_int len64 in
-            let s = String.create len in
+            let s = Bytes.create len in
             Unix32.read fd zero s 0 len;
-            Md5Ext.string s
+            Md5Ext.string @@ Bytes.unsafe_to_string s
           with e ->
               current_job := None;
               raise e

src/daemon/common/commonWeb.ml

@@ -265,7 +265,7 @@ let _ =
               while true do
                 let nread = Unix.read pipe_out buffer 0 buffersize in
                 if nread = 0 then raise End_of_file;
-                Buffer.add_substring output buffer 0 nread
+                Buffer.add_subbytes output buffer 0 nread
               done
              with 
              | End_of_file -> ()

src/daemon/common/giftDecoding.ml

@@ -11,11 +11,11 @@ let gui_cut_messages f sock nread =
   try
     let rec iter pos len =
       if len = 0 then raise Not_found;
-      if b.buf.[pos] = ';' && (
+      if Bytes.get b.buf pos = ';' && (
           pos = b.pos || 
-          (pos > b.pos && b.buf.[pos-1] <> '\\')) then begin
+          (pos > b.pos && Bytes.get b.buf (pos-1) <> '\\')) then begin
           let len = pos - b.pos+1 in
-          let s = String.sub b.buf b.pos len in
+          let s = Bytes.sub_string b.buf b.pos len in
           buf_used b len;
           f s;
           iter b.pos b.len

src/daemon/common/guiDecoding.ml

@@ -42,10 +42,10 @@ let gui_cut_messages f sock nread =
   let b = buf sock in
   try
     while b.len >= 4 do
-      let msg_len = get_int b.buf b.pos in
+      let msg_len = get_int (Bytes.unsafe_to_string b.buf) b.pos in
       if b.len >= 4 + msg_len then
         begin
-          let s = String.sub b.buf (b.pos+4) msg_len in
+          let s = Bytes.sub_string b.buf (b.pos+4) msg_len in
           buf_used b (msg_len + 4);
           let opcode = get_int16 s 0 in
           (f opcode s : unit)

src/daemon/common/guiEncoding.ml

@@ -44,10 +44,10 @@ let gui_send writer sock t =
     Buffer.reset buf;
     buf_int buf 0;
     writer buf t;
-    let s = Buffer.contents buf in
-    let len = String.length s - 4 in
+    let s = Buffer.to_bytes buf in
+    let len = Bytes.length s - 4 in
     str_int s 0 len;
-    write_string sock s;
+    write_bytes sock s
   with UnsupportedGuiMessage -> ()
 
 (***************

src/daemon/driver/driverCommands.ml

@@ -1389,12 +1389,12 @@ let _ =
                  (* can't close pipe_out in the already forked+executed process... *)
                  let output = Buffer.create 1024 in
                  let buffersize = 1024 in
-                 let buffer = String.create buffersize in
+                 let buffer = Bytes.create buffersize in
                  (try
                     while true do
                       let nread = Unix.read pipe_out buffer 0 buffersize in
                       if nread = 0 then raise End_of_file;
-                      Buffer.add_substring output buffer 0 nread
+                      Buffer.add_subbytes output buffer 0 nread
                     done
                   with 
                   | End_of_file -> ()
@@ -3897,7 +3897,7 @@ let _ =
            let downloaded = CommonSwarming.get_swarmer_block_verified swarmer in
            pr "\\<code\\>";
            pr "priorities: ";
-           String.iter (fun c ->
+           Bytes.iter (fun c ->
              let c = max 0 (min 9 (Char.code c)) in
              let c = Char.chr (c + Char.code '0') in 
              Buffer.add_char buf c) prio;