Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test according to main PR #293

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Update test according to main PR #293

merged 11 commits into from
Apr 12, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 6, 2024

Main PR

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Enhancements to CommandTest.php
    The CommandTest.php file now has added improvements, specifically on the testUpdate method. This method has been equipped with new parameters - expectedValues and expectedCount. These additions are now enabling the method to call its parent testUpdate method along with integrating these new parameters.

  • Addition of New Method in QueryBuilderTest.php
    A new method, testUpdate, has been introduced in the QueryBuilderTest.php file. This method incorporated additional parameters called expectedParams and expectedSql. The purpose of these parameters is to help this method to invoke the parent testUpdate method in conjunction with its additional parameters.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (71ab38b) to head (f6bf9ea).
Report is 2 commits behind head on master.

❗ Current head f6bf9ea differs from pull request most recent head 75700fd. Consider uploading reports for the commit 75700fd to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
+ Coverage     98.01%   98.10%   +0.08%     
- Complexity      208      218      +10     
============================================
  Files            15       17       +2     
  Lines           604      632      +28     
============================================
+ Hits            592      620      +28     
  Misses           12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

rector.php Show resolved Hide resolved
@vjik vjik merged commit ca6e276 into master Apr 12, 2024
2 of 3 checks passed
@vjik vjik deleted the fix-update-with-expressions branch April 12, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants