-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process expressions inside param values when build a query #806
Conversation
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
============================================
+ Coverage 99.55% 99.56% +0.01%
- Complexity 1277 1316 +39
============================================
Files 63 64 +1
Lines 3120 3228 +108
============================================
+ Hits 3106 3214 +108
Misses 14 14 ☔ View full report in Codecov by Sentry. |
…name. Fix unique param name w/ and w/o colon
*/ | ||
public function __construct(protected string $sql) | ||
{ | ||
$this->length = strlen($sql); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could SQL contain unicode strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems with UTF-8 or any single-byte encoding.
Should it support other multibyte encodings? If should, it could be a problem to pass that encoding to the parser.
Co-authored-by: Alexander Makarov <[email protected]>
# Conflicts: # UPGRADE.md
Expression::$params
(they will be replaced with unique names)Expression
instances insideExpression::$params
Related PRs